XMLSerializer: Keep redundant but harmless default namespace declarations #15779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 12, 2019
annevk
reviewed
Mar 12, 2019
| @@ -145,8 +152,6 @@ <h1>domparsing_XMLSerializer_serializeToString</h1> | |||
|
|
|||
| test(function() { | |||
| assert_equals(serialize(parse('<root><child/></root>')), '<root><child/></root>'); | |||
| assert_equals(serialize(parse('<root><child xmlns=""/></root>')), '<root><child/></root>'); | |||
There was a problem hiding this comment.
It seems we lost this particular input @tkent-google. A root without xmlns declaration and a child with one. Could you restore that?
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1516124
branch
2 times, most recently
from
098f676
to
ec47d94
Compare
…ions Since crrev.com/632142, XMLSerializer has dropped redundant xmlns="..." declarations. It matches to IE, Edge, and DOM P&S standard. This CL reverts the behavior to unbreak existing applications. The restored behavior matches to Firefox and Safari. * MarkupAccumulator::AppendElement(): Even if ignore_namespace_definition_attribute_ is set, we drop a xmlns="..." only if its value is inconsistent with element's namespace. * MarkupAccumulator::AppendStartTagOpen(): if local_default_namespace is "" and ns is null, do not emit xmlns="". This avoids to serialize xmlns="" twice. Bug: w3c/DOM-Parsing#47 Bug: 940204 Change-Id: I2978ddc9a3f9511d227a9a1b902f1811ac1c3c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516124 Reviewed-by: Yoshifumi Inoue <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Auto-Submit: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/master@{#639873}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1516124
branch
from
ec47d94
to
dfc064d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since crrev.com/632142, XMLSerializer has dropped redundant xmlns="..."
declarations. It matches to IE, Edge, and DOM P&S standard. This CL
reverts the behavior to unbreak existing applications. The restored
behavior matches to Firefox and Safari.
MarkupAccumulator::AppendElement():
Even if ignore_namespace_definition_attribute_ is set, we drop a
xmlns="..." only if its value is inconsistent with element's
namespace.
MarkupAccumulator::AppendStartTagOpen():
if local_default_namespace is "" and ns is null, do not emit xmlns="".
This avoids to serialize xmlns="" twice.
Bug: w3c/DOM-Parsing#47
Bug: 940204
Change-Id: I2978ddc9a3f9511d227a9a1b902f1811ac1c3c07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516124
Reviewed-by: Yoshifumi Inoue <[email protected]>
Commit-Queue: Kent Tamura <[email protected]>
Auto-Submit: Kent Tamura <[email protected]>
Cr-Commit-Position: refs/heads/master@{#639873}