Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard pages for fiber stacks #26

Closed
dhil opened this issue Oct 16, 2023 · 2 comments · Fixed by #169
Closed

Guard pages for fiber stacks #26

dhil opened this issue Oct 16, 2023 · 2 comments · Fixed by #169
Labels
bug Something isn't working

Comments

@dhil
Copy link
Member

dhil commented Oct 16, 2023

Our custom malloc for fiber stacks do not include guard pages, so a stack overflow may result in a corrupted program.
@dhil dhil added the bug Something isn't working label Oct 16, 2023
@dhil
Copy link
Member Author

dhil commented Jan 30, 2024

Related #61.

@dhil dhil mentioned this issue Feb 23, 2024
Closed
@dhil
Copy link
Member Author

dhil commented May 14, 2024

Fixed by #169.

@dhil dhil mentioned this issue May 14, 2024
Merged
@dhil dhil closed this as completed in #169 May 22, 2024
dhil added a commit that referenced this issue May 22, 2024
@dhil
Basic stack pooling allocator (#169)
b428c49 
This patch adds a basic stack pooling allocator for WasmFX stacks. It is
gated behind a feature flag `wasmfx_pooling_allocator`, which is
disabled by default. By default
stacks are safe, meaning they have a page guard attached. The old unsafe
stacks are gated behind the feature flag `unsafe_wasmfx_stacks`.

In addition, this patch also adds missing WasmFX features to
`wasmtime-c-api` and `wasmtime-c-api-impl`.

Resolves #91. Resolves #26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basic stack pooling allocator dhil/wasmtime
1 participant
@dhil