Fix WASIX additional imports so it works with new threads as well #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
approved these changes
Sep 25, 2024
|
I'd like to review this in more detail before merging |
syrusakbary
reviewed
Oct 24, 2024
| &self, | ||
| store: &'a (impl AsStoreRef + ?Sized), | ||
| ) -> MemoryView<'a> { | ||
| pub unsafe fn memory_view<'a>(&self, store: &'a (impl AsStoreRef + ?Sized)) -> MemoryView<'a> { |
There was a problem hiding this comment.
We can remove this, so the user expect themselves
syrusakbary
reviewed
Oct 24, 2024
| self.try_inner().map(|i| i.memory()) | ||
| } | ||
|
|
||
| /// Providers safe access to the memory | ||
| /// (it must be initialized before it can be used) | ||
| /// This has been marked as unsafe as it will panic if its executed | ||
| /// on the wrong thread or before the inner is set | ||
| pub(crate) unsafe fn memory(&self) -> WasiInstanceGuardMemory<'_> { | ||
| pub unsafe fn memory(&self) -> WasiInstanceGuardMemory<'_> { |
There was a problem hiding this comment.
We can remove this, so the user expect themselves
|
@syrusakbary do you still want to do an in-depth review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.