Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes of two formatting issues with types defined inside REPL #306

Conversation

kindermannhubert
Copy link
Collaborator

Fixes #287.
Fixes #305.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f5af0da) 77.5% compared to head (89617fc) 77.5%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #306   +/-   ##
=====================================
  Coverage   77.5%   77.5%           
=====================================
  Files         83      83           
  Lines       5573    5575    +2     
  Branches     733     735    +2     
=====================================
+ Hits        4324    4326    +2     
  Misses       982     982           
  Partials     267     267           
Files Coverage Δ
...pl.Services/Roslyn/Formatting/TypeNameFormatter.cs 88.7% <100.0%> (+0.1%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kindermannhubert kindermannhubert merged commit 9b1f059 into waf:main Sep 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve formatting of generic types defined inside REPL Formatting problem with types defined inside REPL
1 participant