Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Privacy] Adds notes clarifying behavior to address privacy review. #83

Merged
merged 15 commits into from
Jun 16, 2017

Conversation

markafoltz
Copy link
Contributor

Addresses:

@avayvod @mounirlamouri PTAL

index.html Outdated
identity of the <a>media element</a> alone, and not the identity
of the browser profile or any <a>remote playback device</a>. For
example, the user agent could base the <var>callbackId</var> on
the timestamp the <a>media element</a> was created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this example implies the callback ids must be unique across all the media elements within a browser session which is not true. They only must be unique for each media element alone. An example is a counter in the media element's scope, that's set to 0 when the media element is created and is incremented each time its value is returned by watchAvailability() for this particular element as the callback id.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems inconvenient if a page is watching availability on multiple elements and wants to keep the callbacks in a Map or otherwise track the set of callbacks by id.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. It might be more likely having one callback per many elements compared to many callbacks for a single element. The spec doesn't guarantee any cross-element uniqueness of the ids at the moment though.

@jernoble @mounirlamouri WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this requires discussion in a separate issue. I'll remove the example from this PR and suggest it separately.

index.html Outdated
@@ -1374,10 +1384,11 @@
"RemotePlayback">watchAvailability</a>()</code> method reveals one
bit of information about the presence (or non-presence) of a
<a>remote playback device</a> typically discovered through the local
area network. This could be used in conjunction with other
area network. This could be used in conjunction with other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: accidental whitespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

index.html Outdated
stop <a data-lt="monitor the list of available remote playback devices">
monitoring the list of available remote playback devices</a>
and will clear the <a>global set of availability callbacks</a>. In
this state, pages will receive no further information about the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems broken if the last known information was that the availability is true. Also, there's no way for the pages to know the callback ids became invalid. I think in this case the UA should just report the availability as false and stop reporting availability through the callbacks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an issue with the steps to disable remote playback. It clears the callbacks and does not invoke them with false before doing so.

index.html Outdated
<p>
If a user <a data-lt="disable remote playback">disables remote
playback</a> on all <a data-lt="media element">media elements</a>
(through a browser setting, for example), the user agent should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the use of should and will here. If we're defining the behavior in the response of a user setting, MUST would be preferred (by the definition of the user agent). However, we don't spec browser settings here and it's just a note.

Maybe something like "The user agent MAY at any time stop monitoring the list of available remote playback devices if the user disables remote playback (for example through a browser setting). In this case the availability callbacks MUST be fired with false and their ids will remain valid however they MAY never be fired again." is more focused on the API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased as suggested. However disabling remote playback doesn't fire any callbacks as noted above.

index.html Outdated
remote playback devices"> monitoring the list of available remote
playback devices</a> at any time if the user disables remote playback
(for example, through a browser setting). In this state, pages will
receive no further information about the availability of <a>remote
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In such a scary (to web authors) scenario I think firing the callbacks with availability set to false if needed would be nice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the normative part of the spec should then describe the behavior of stop monitoring the list of remote playback devices. I'll drop the last sentence and file this as an enhancement.

@anssiko
Copy link
Member

anssiko commented Jun 12, 2017

@avayvod it looks like this could be merged, since @mfoltzgoogle addressed your comments.

Should land this PR that addresses the privacy review feedback prior to CR #73.

@anssiko anssiko mentioned this pull request Jun 12, 2017
17 tasks
@markafoltz
Copy link
Contributor Author

I've updated it to no longer mention disabling remote playback to avoid any confusion with the disableRemotePlayback attribute.

@avayvod avayvod merged commit 4249227 into w3c:gh-pages Jun 16, 2017
@markafoltz markafoltz deleted the privacy-updates branch June 7, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants