-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VTreeview): prevent redundant treeview re-render during open #19968
Conversation
@@ -146,7 +147,8 @@ export const VTreeview = genericComponent<new <T>( | |||
}) | |||
|
|||
useRender(() => { | |||
const listProps = VList.filterProps(props) | |||
const listProps = VList.filterProps(vm.vnode.props!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid non-existing prop being assigned as undefined
to VList
If @update:opened="openedListener"
is used in Treeview, VList.filterProps(props)
is equivalent to <VList :opened="undefined" @update:opened="openedListener">
, which breaks VList demo
This does provide an improvement, but it's still very slow and only appears to work when opening and closing a single group. When you move to the next one or back, it's still a 2-3 second delay before it displays. |
The remaining latency is caused by vuejs/babel-plugin-jsx#712. If you remove |
fixes #19919
Description
v-model:opened
changeMarkup: