-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): deal with new sass restriction #13704
Conversation
I checked the build on both this and master with my update and the files are identical. With that being said, we should probably opt to wrap our division in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use math.div
instead of muliplication
packages/vuetify/src/components/VCalendar/mixins/__tests__/calendar-with-events.spec.ts
Outdated
Show resolved
Hide resolved
This is deprecated too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means everywhere. If you want to propose testing changes that can be a separate pr
Wow, that's some big breaking change from sass.. I mean they could have opted for another character to handle grids... Instead of breaking every single division out there.. It would have seemed like the more reasonable approach Oh well |
89d8b72
to
13030ab
Compare
@mcdmaster is attempting to deploy a commit to the Vuetify Team on Vercel. A member of the Team first needs to authorize it. |
a295175
to
6190b9b
Compare
@KaelWD Done. Please check. Thanks |
packages/vuetify/src/components/VProgressLinear/VProgressLinear.sass
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains multiple commits that have nothing to do with this bug fix. Can you please remove them.
24288e3
to
d1c8207
Compare
63581f0
to
006b377
Compare
Looking good. What is the reason behind the CI changes? |
@johnleider Thank you. BTW, I was not confident with my CI credentials properly registered. |
2a8604f
to
006b377
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is failing and still shows some deprecation notices, please double-check your work.
a2f8f5d
to
46365fc
Compare
46365fc
to
1ce7f67
Compare
cf. https://sass-lang.com/documentation/breaking-changes/slash-div
To deal with this new SASS anti-slash-div facility
Fixes #13694
Fixes Tokyo-Metro-Gov/covid19#6346
Description
Motivation and Context
Other applications implementing SASS plus Vuetify are impacted on the change done by SASS
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).