Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): deal with new sass restriction #13704

Closed
wants to merge 6 commits into from

Conversation

mcdmaster
Copy link

@mcdmaster mcdmaster commented May 25, 2021

cf. https://sass-lang.com/documentation/breaking-changes/slash-div
To deal with this new SASS anti-slash-div facility

Fixes #13694
Fixes Tokyo-Metro-Gov/covid19#6346

Description

Motivation and Context

Other applications implementing SASS plus Vuetify are impacted on the change done by SASS

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider
Copy link
Member

johnleider commented May 25, 2021

I checked the build on both this and master with my update and the files are identical. With that being said, we should probably opt to wrap our division in #{} as opposed to switching to multiplication. Either way, I'd still like @KaelWD to take a look at this.

@johnleider johnleider requested a review from KaelWD May 25, 2021 23:15
@johnleider johnleider added this to the v2.5.x milestone May 25, 2021
@johnleider johnleider added sass T: bug Functionality that does not work as intended/expected labels May 25, 2021
Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use math.div instead of muliplication

@KaelWD
Copy link
Member

KaelWD commented May 26, 2021

we should probably opt to wrap our division in #{}

This is deprecated too.

Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means everywhere. If you want to propose testing changes that can be a separate pr

@mcdmaster mcdmaster requested a review from KaelWD May 26, 2021 11:59
@Tofandel
Copy link
Contributor

Wow, that's some big breaking change from sass.. I mean they could have opted for another character to handle grids... Instead of breaking every single division out there.. It would have seemed like the more reasonable approach

Oh well

@vercel
Copy link

vercel bot commented May 26, 2021

@mcdmaster is attempting to deploy a commit to the Vuetify Team on Vercel.

A member of the Team first needs to authorize it.

@mcdmaster
Copy link
Author

That means everywhere. If you want to propose testing changes that can be a separate pr

@KaelWD Done. Please check. Thanks

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@mcdmaster mcdmaster requested a review from KaelWD May 28, 2021 16:18
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains multiple commits that have nothing to do with this bug fix. Can you please remove them.

@mcdmaster mcdmaster force-pushed the fix/sass-division branch 2 times, most recently from 24288e3 to d1c8207 Compare May 28, 2021 18:11
@johnleider
Copy link
Member

Looking good. What is the reason behind the CI changes?

@mcdmaster
Copy link
Author

@johnleider Thank you. BTW, I was not confident with my CI credentials properly registered.
Can you please let me know if it is better to withdraw the last commit of mine?

Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing and still shows some deprecation notices, please double-check your work.

@johnleider johnleider added the P: high The issue is of high importance label May 31, 2021
@mcdmaster mcdmaster requested a review from KaelWD June 1, 2021 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: high The issue is of high importance sass T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SASS / SCSS の割り算の記法 [Bug Report][2.5.0] New Sass Deprecation Recommended
4 participants