Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle extra folders with the installer when doing -Pbundle-with-installer #539

Open
Michaelpalacce opened this issue Nov 27, 2024 · 1 comment
Labels
area/installer Relates to the solution installer effort/low kind/feature New Feature to the project lang/java Related to Java Code priority/medium triage/accepted The issue was accepted and will be done version/minor Introduces a non-breaking feature or change

Comments

@Michaelpalacce
Copy link
Collaborator

Michaelpalacce commented Nov 27, 2024

Description

There is a need of having several files and directories coming as part of the bundle (artifact), hence it will be good if we have a way to choose data from the repository to be exported and be bundled. Example of such data ins installJson file, which is used by workflow installer (more examples can be given on demand). To achieve this, we can use pom.xml file in parent directory, adding a property for export, ex:
cat pom.xml

...
        <properties>
		<maven.deploy.skip>true</maven.deploy.skip>
		<generated.from>ts-vra-ng</generated.from>
		<additional.bundle.content>"infrastructure-specs/response-files/install_wf.yaml","infrastructure-specs/response-files/environment.properties","integration-tests/"</additional.bundle.content>
	</properties>
	<build>
		<plugins>
...

We can store all of these exports within bin directory (configurable ?). Also, it is good to add some checks like:

  • file/directory doesn't exist -> mvn build error
  • export if a file not from repository ("../../some_file.txt") --> mvn build error
@uthery
Copy link

uthery commented Nov 27, 2024

Requirements updated.

@VenelinBakalov VenelinBakalov added lang/java Related to Java Code area/installer Relates to the solution installer version/minor Introduces a non-breaking feature or change triage/accepted The issue was accepted and will be done kind/feature New Feature to the project priority/medium effort/low labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installer Relates to the solution installer effort/low kind/feature New Feature to the project lang/java Related to Java Code priority/medium triage/accepted The issue was accepted and will be done version/minor Introduces a non-breaking feature or change
Projects
None yet
Development

No branches or pull requests

3 participants