Jasmine types mismatch between vrotest and vropkg #516
Labels
area/tests
Relates to tests and code coverage
kind/bug
Something isn't working
priority/medium
triage/needed
Needs to be discussed by project maintainers
version/patch
The change is a non-breaking bugfix
Description
The package
@types/jasmine
(andjasmine
itself) have a version mismatch betweenvropkg
andvrotest
.While the
jasmine
package itself did not give me issues, the@types/jasmine
does.The following example should work, type wise.
It will work inside the editor and (most of the time) when running
mvn clean package
:But sometimes it generates the error:
error Type 'Spy' is not assignable to type 'SpyObj<MyService>'.
As you can see in the links below, when you search for
spyOnAllFunctions
the definitions don't match3.3.9: https://www.npmjs.com/package/@types/jasmine/v/3.3.9?activeTab=code
3.10.3: https://www.npmjs.com/package/@types/jasmine/v/3.10.3?activeTab=code
Steps to Reproduce
jasmine.SpyObj<MyService>
with something from spyOnAllFunctionsmvn clean package
Preconditions: Unsure
Expected behavior: To have it use the correct type definitions
Actual behavior: It (sometimes) uses the old type definitions, which then errors during type checking
Reproduces how often: Unsure, but haven't found a case where it reproduces 100%
Component/s:
typescript/vrotest
,typescript/vropkg
Affects Build/s: Up to
2.44.0
Related issues and PRs
#463
#332
Additional Context
Unsure if the
jasmine
package itself should also be upgraded, since vropkg uses^3.3.1
and vrotest uses4.5.0
The text was updated successfully, but these errors were encountered: