Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change metadata.name in catalog-info.yaml to match accelerator name #49

Open
trisberg opened this issue Sep 14, 2022 · 2 comments · Fixed by #61
Open

Change metadata.name in catalog-info.yaml to match accelerator name #49

trisberg opened this issue Sep 14, 2022 · 2 comments · Fixed by #61
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@trisberg
Copy link
Member

The name in the catalog-info.yaml file should match the accelerator name so someone using the defaults to generate a project could use this file to register the component with the Backstage catalog.

metadata:
  name: sample-app

This applies to weatherforecast-csharp and weatherforecast-steeltoe samples.

@trisberg trisberg added enhancement New feature or request good first issue Good for newcomers labels Sep 14, 2022
@doddatpivotal
Copy link
Contributor

Will also require associated updates to accelerator.yaml

@dmbelyaev
Copy link
Contributor

There is no need to update weatherforecast-csharp and weatherforecast-steeltoe cause this dummy name (sampl-app) will always be replaced during an accelerator execution.

But there are 2 other accelerators where there is no name replacement at all: appsso-starter-java and spring-smtp-gateway. We'll update these 2 in the scope of this task.

@ext-jaret ext-jaret linked a pull request Sep 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants