[10/n][pipeline-gen] Add helper method to convert test step into Buildkite step #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
khluu
commented
Oct 24, 2024
scripts/pipeline_generator/plugin.py
Outdated
| @@ -54,6 +54,7 @@ class DockerPluginConfig(BaseModel): | |||
| command: List[str] = Field(default_factory=list) | |||
| environment: List[str] = DEFAULT_DOCKER_ENVIRONMENT_VARIBLES | |||
| volumes: List[str] = DEFAULT_DOCKER_VOLUMES | |||
| shell: List[str] = ["/bin/bash", "-c"] | |||
There was a problem hiding this comment.
This file contains changes from https://github.com/vllm-project/buildkite-ci/pull/49/files which would be rebased after that PR is merged to main
aslonnie
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestStepintoBuildkiteStepbased on whether the test is a regular one or a multi node one (since multi-node test uses a custom script to run)PipelineGeneratorwhere the test steps are processed intoBuildkiteStepandBuildkiteBlockStep. The next PR will add the method since it contains some logic that is better to put in a separate PR. The logic is here: https://github.com/vllm-project/buildkite-ci/pull/36/files#diff-82edd9d64d3e791b9faade2e3aff441908121926000ca52bd54a8f17c976f4d0R120