Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml: cannot decode tables into maps #22634

Open
gechandesu opened this issue Oct 23, 2024 · 1 comment
Open

toml: cannot decode tables into maps #22634

gechandesu opened this issue Oct 23, 2024 · 1 comment
Labels
Bug This tag is applied to issues which reports bugs. Unit: vlib Bugs/feature requests, that are related to the vlib.

Comments

@gechandesu
Copy link

gechandesu commented Oct 23, 2024

Describe the bug

The subject.

Reproduction Steps

module main

import toml

struct Item {
	name string
}

struct Doc {
	items map[string]Item
}

fn main() {
	doc := Doc{
		items: {
			'first':  Item{
				name: 'first one'
			}
			'second': Item{
				name: 'second one'
			}
		}
	}
	encoded := toml.encode[Doc](doc)
	decoded := toml.decode[Doc](encoded)!

	assert decoded == doc
}

Expected Behavior

Assertion passed.

Current Behavior

decoded.items is empty:

~ $ v run toml_issue_.v
toml_issue_.v:27: FAIL: fn main.main: assert decoded == doc
   left value: decoded = Doc{
    items: {}
}
  right value: doc = Doc{
    items: {'first': Item{
        name: 'first one'
    }, 'second': Item{
        name: 'second one'
    }}
}
V panic: Assertion failed...
v hash: 97c6cd0
/tmp/v_1000/toml_issue_.01JAX6P20BN5TX8R9NGB7F3229.tmp.c:10411: at _v_panic: Backtrace
/tmp/v_1000/toml_issue_.01JAX6P20BN5TX8R9NGB7F3229.tmp.c:30554: by main__main
/tmp/v_1000/toml_issue_.01JAX6P20BN5TX8R9NGB7F3229.tmp.c:30873: by main

Possible Solution

No response

Additional Information/Context

No response

V version

V 0.4.8 97c6cd0

Environment details (OS name and version, etc.)

V full version: V 0.4.8 5ec9bb5.97c6cd0
OS: linux, Linux version 6.6.8-arch1-1 (linux@archlinux) (gcc (GCC) 13.2.1 20230801, GNU ld (GNU Binutils) 2.41.0) #1 SMP PREEMPT_DYNAMIC Thu, 21 Dec 2023 19:01:01 +0000
Processor: 16 cpus, 64bit, little endian, 12th Gen Intel(R) Core(TM) i5-1240P

getwd: /home/ge
vexe: /home/ge/.vlang/v
vexe mtime: 2024-10-23 16:44:23

vroot: OK, value: /home/ge/.vlang
VMODULES: OK, value: /home/ge/.vmodules
VTMP: OK, value: /tmp/v_1000

Git version: git version 2.46.1
Git vroot status: weekly.2024.43-20-g97c6cd09
.git/config present: true

CC version: cc (GCC) 14.2.1 20240910
thirdparty/tcc status: thirdparty-linux-amd64 0134e9b9

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21083

@gechandesu gechandesu added the Bug This tag is applied to issues which reports bugs. label Oct 23, 2024
@gechandesu
Copy link
Author

The workaround is parsing by hand using from_toml() method.

Code

module main

import maps
import toml

struct Item {
	name string
}

struct Doc {
mut:
	items map[string]Item
}

fn (mut d Doc) from_toml(doc toml.Any) {
	items := doc.as_map()['items'] or { toml.Any(map[string]toml.Any{}) }.as_map()
	for key, val in items {
		item := {
			key: Item{
				name: val.as_map()['name'] or { toml.Any{} }.string()
			}
		}
		maps.merge_in_place(mut d.items, item)
	}
}

fn main() {
	doc := Doc{
		items: {
			'first':  Item{
				name: 'first one'
			}
			'second': Item{
				name: 'second one'
			}
		}
	}
	encoded := toml.encode[Doc](doc)
	decoded := toml.decode[Doc](encoded)!

	assert decoded == doc
}

@felipensp felipensp added the Unit: vlib Bugs/feature requests, that are related to the vlib. label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Unit: vlib Bugs/feature requests, that are related to the vlib.
Projects
None yet
Development

No branches or pull requests

2 participants