Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #668 #673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ymajoros
Copy link

@ymajoros ymajoros commented Nov 7, 2023

No description provided.

@ymajoros
Copy link
Author

ymajoros commented Nov 8, 2023

#675 actually solves it in a better way. They could still be split in 2, but I think it's not worth it, as further refactorings were needed.

@vladmihalcea
Copy link
Owner

@ymajoros Why make all these changes instead of just doing this instead?

String sql = SQLExtractor.from(criteriaQuery.unwrap(Query.class));

ymajoros pushed a commit to ymajoros/hypersistence-utils that referenced this pull request Nov 13, 2023
@ymajoros
Copy link
Author

@vladmihalcea this seems to indeed simplify it. I updated #675 with that, as it was needed there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants