Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow list in SpatialBone setBoneValue #1335

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: Allow list in SpatialBone setBoneValue #1335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7baccb1
Allow list in SpatialBone setBoneValue
ArneGudermann Nov 26, 2024
251034a
Merge branch 'main' into fix/SpatialBone_setBoneValue_list
phorward Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/viur/core/bones/spatial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,9 @@ def setBoneValue(
"""
if append:
raise ValueError(f"append is not possible on {self.type} bones")
assert isinstance(value, tuple) and len(value) == 2, "Value must be a tuple of (lat, lng)"
skel[boneName] = value
if not isinstance(value, (tuple, list)) and len(value) == 2:
raise ValueError("Value must be a tuple or a list of (lat, lng)")
skel[boneName] = tuple(value)

def structure(self) -> dict:
return super().structure() | {
Expand Down