Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisIt crashes down in VTK saving an image with more that 0.5 Gbytes of pixels. #20042

Open
brugger1 opened this issue Nov 14, 2024 · 2 comments
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood

Comments

@brugger1
Copy link
Collaborator

When you try and save an image that contains more than 0.5Gbytes of pixels, VTK crashes reading back the pixels from Mesa. Right now VisIt has logic that prevents the user from doing this, so that logic will need to be disabled to replicate the crash.

@brugger1 brugger1 added bug Something isn't working likelihood medium Neither low nor high likelihood impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) labels Nov 14, 2024
@JustinPrivitera
Copy link
Member

Can you put a link here to the logic that would need to be removed?

@brugger1
Copy link
Collaborator Author

The logic to remove is in ViewerWindowManager::SaveWindow.

	    // if the total image size is too large, reduce them
	    // proportionally.
	    if (w * h > 536756224)
            {
                double image_size = (double)(w * h);
                w = (int)((double)w * std::sqrt(536756224. / image_size));
                h = (int)((double)h * std::sqrt(536756224. / image_size));
                GetViewerMessaging()->Message(
                    TR("The window was too large to save at the requested resolution.  "
                       "The resolution has been automatically reduced."));
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood
Projects
None yet
Development

No branches or pull requests

2 participants