Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-package redux ❤️ #44

Open
jspc opened this issue Mar 11, 2022 · 0 comments
Open

Multi-package redux ❤️ #44

jspc opened this issue Mar 11, 2022 · 0 comments

Comments

@jspc
Copy link
Member

jspc commented Mar 11, 2022

Rather than the current approach of iterating through packages in vin install [foo|bar|baz], we should accept many packages here https://github.com/vinyl-linux/vin/blob/main/server/install.pb.go#L27-L35

At that point we can create a meta-package on the fly when Pkg has many packages.

These on-the-fly meta-packages don't need to be added to world.
jspc added a commit that referenced this issue Mar 11, 2022
@jspc
Install multiple packages together as a meta package
e554374 
Because we now support triggers, and because triggers need to run at the absolute end, and because the potential install loop is a pain, we can install build a meta package when many packages are set. So long as that package stays out of the state db, so much the better.

See: #44
@jspc jspc mentioned this issue Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jspc