Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price notifications #28

Open
vinniejames opened this issue Sep 10, 2017 · 9 comments
Open

Price notifications #28

vinniejames opened this issue Sep 10, 2017 · 9 comments

Comments

@vinniejames
Copy link
Owner

Add price hi/low notifications

@vinniejames
Copy link
Owner Author

@williamluke4 I'm most interested in getting this one going. Adding browser notifications / push alerts for pricing

@williamluke4
Copy link
Contributor

@vinniejames Will have look in to service workers

@vinniejames
Copy link
Owner Author

Yes, exactly, @williamluke4 ! Would you be interested in doing a bit of research here and/or submitting a PR?

Ideally, I'd like users to be able to select an upper/lower bound to receive an alert, eg Ethereum price: ping when price drops below $500 or above $1500

@williamluke4
Copy link
Contributor

Yeah shouldn't be too hard!

@williamluke4
Copy link
Contributor

@vinniejames Well I was wrong! This would require a backend server to send push notification to the app.

@vinniejames
Copy link
Owner Author

Setting up a server wouldn't be out of the question. I wonder if it could be accomplished instead using something like this: https://blog.cloudflare.com/cloudflare-workers-unleashed/amp/

@williamluke4
Copy link
Contributor

@vinniejames Yeah that would work! Just quickly setup serviceworker push notification in a separate branch!

@williamluke4
Copy link
Contributor

Though we could use periodicSync to check the market but its still in development and wouldn't give live notifications

@vinniejames
Copy link
Owner Author

vinniejames commented Apr 15, 2018

Nice, let me know if you make some progress implementing the serviceWorker! I can move it over to a server environment if need be once a PR is ready.

Looks like periodicSync wont work on Safari, so if you want to try that route please make sure there is a fallback for Safari users

Repository owner deleted a comment from renato71amorim Mar 4, 2024
@github-staff github-staff deleted a comment from apocanow1 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants