-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Price notifications #28
Comments
@williamluke4 I'm most interested in getting this one going. Adding browser notifications / push alerts for pricing |
@vinniejames Will have look in to service workers |
Yes, exactly, @williamluke4 ! Would you be interested in doing a bit of research here and/or submitting a PR? Ideally, I'd like users to be able to select an upper/lower bound to receive an alert, eg Ethereum price: ping when price drops below $500 or above $1500 |
Yeah shouldn't be too hard! |
@vinniejames Well I was wrong! This would require a backend server to send push notification to the app. |
Setting up a server wouldn't be out of the question. I wonder if it could be accomplished instead using something like this: https://blog.cloudflare.com/cloudflare-workers-unleashed/amp/ |
@vinniejames Yeah that would work! Just quickly setup serviceworker push notification in a separate branch! |
Though we could use periodicSync to check the market but its still in development and wouldn't give live notifications |
Nice, let me know if you make some progress implementing the serviceWorker! I can move it over to a server environment if need be once a PR is ready. Looks like periodicSync wont work on Safari, so if you want to try that route please make sure there is a fallback for Safari users |
Add price hi/low notifications
The text was updated successfully, but these errors were encountered: