Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in events for audio vs. subtitle tracks. #6798

Open
matvp91 opened this issue Oct 22, 2024 · 0 comments
Open

Discrepancy in events for audio vs. subtitle tracks. #6798

matvp91 opened this issue Oct 22, 2024 · 0 comments
Labels
Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix.

Comments

@matvp91
Copy link
Contributor

matvp91 commented Oct 22, 2024

Is your feature request related to a problem? Please describe.

As discussed earlier, writing this down so it doesn't end up in limbo.

From an API perspective, audio and subtitle tracks are quite similar and can both be treated as definitions of a Track.

For audio tracks, specific events indicate when a track is in the process of switching or has switched: Events.AUDIO_TRACK_SWITCHING and Events.AUDIO_TRACK_SWITCHED, respectively. For subtitle tracks, only one event is used: Events.SUBTITLE_TRACK_SWITCH.

There's Events.SUBTITLE_FRAG_PROCESSED too but the same type of event is lacking for audio. I'm not entirely sure if this should be streamlined too, but since we're at it, why not?

Describe the solution you'd like

It makes sense to streamline this behavior and introduce an Events.SUBTITLE_TRACK_SWITCHING too.

Additional context

N/A

@matvp91 matvp91 added Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix. labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature proposal Needs Triage If there is a suspected stream issue, apply this label to triage if it is something we should fix.
Projects
None yet
Development

No branches or pull requests

1 participant