Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network parameter validation on proposals #2355

Closed
davidsiska-vega opened this issue Sep 2, 2024 · 1 comment
Closed

Network parameter validation on proposals #2355

davidsiska-vega opened this issue Sep 2, 2024 · 1 comment
Assignees

Comments

@davidsiska-vega
Copy link
Contributor

We can validate parameter ranges at proposal submission (and I believe we do).

However, relation to anything dynamic, especially other parameter values must only happen at enactment time:

  • if, at enactment time validation against other dynamic values (other parameter values) passes, proposal goes ahead
  • else proposal fails (and if this is part of a batch then only this part of the batch fails, the rest remains scheduled as when it passed voting).

We need to:

  • update spec to make this clear
  • add an AC
@witgaw
Copy link
Contributor

witgaw commented Sep 18, 2024

#2362

@witgaw witgaw closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants