Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume discount spec update to better target maker rebate #2292

Closed
davidsiska-vega opened this issue Jun 4, 2024 · 1 comment · Fixed by #2293
Closed

Volume discount spec update to better target maker rebate #2292

davidsiska-vega opened this issue Jun 4, 2024 · 1 comment · Fixed by #2293
Assignees
@TomMcL
Milestone
🏛️ Colosseo II

Comments

@davidsiska-vega
Copy link
Contributor

Following the feedback - I would suggest we either
a) update the volume discount code / spec to remove maker fee from being subjected to the discount.
b) update the volume discount code / spec so that the volume discount specifically says which of the fee components it’s hitting. So to replicate the current behaviour you’ll have to submit 3 blobs: one for maker fee, one for LP fee and one for infra fee.
@davidsiska-vega davidsiska-vega added this to the 🏛️ Colosseo II milestone Jun 4, 2024
@TomMcL TomMcL mentioned this issue Jun 5, 2024
Merged
@TomMcL TomMcL self-assigned this Jun 26, 2024
@ze97286 ze97286 mentioned this issue Jul 4, 2024
Closed
@witgaw witgaw linked a pull request Jul 8, 2024 that will close this issue
feat: separate fee discount components #2293
Merged
@davidsiska-vega
Copy link
Contributor Author

Closed by #2293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomMcL TomMcL

Labels
None yet
Projects
None yet
Milestone
🏛️ Colosseo II
Development

Successfully merging a pull request may close this issue.

feat: separate fee discount components vegaprotocol/specs
2 participants
@TomMcL @davidsiska-vega