Skip to content

Commit

Permalink
feat(colosseo): Merge colosseo into master (#2302)
Browse files Browse the repository at this point in the history
* chore: updates for approbation after the branch rename (#2150)

After renaming the nebula branch to colosseo this will ensure that approbation runs as required on the CI

* chore: renove dupe AC from features file (#2151)

* feat: move reward cap to 0057

* chore: typo

* feat: comment from Barney

Co-authored-by: Barnaby M <[email protected]>

* feat: address comment from Barney

Co-authored-by: Barnaby M <[email protected]>

* feat: add details calculating reward

* feat: add quantum

* chore: add deatails about the max proposals in a batch

This updates the spec to details the max number of proposals that can be submitted in a single batch proposal

* feat: remove redundant line

* feat: add minBalance parameter

* feat: address comments

* feat: add AC

* chore: add teams spam protection (#2157)

Copies the changes made to the Colosseo branch here:

- https://github.com/vegaprotocol/specs/pull/2156

* feat: add ac to 0019

* chore: add features.json entries

* fix: dupe ACs

* chore: add update team spam ACs (#2159)

* chore: add update team spam ACs

Adds in ACs for also updating referral sets / teams and spam protection

* fix: spelling

* chore: Update protocol/0062-SPAM-spam_protection.md

Co-authored-by: Jiajia-Cui <[email protected]>

* chore: Update protocol/features.json

Co-authored-by: Jiajia-Cui <[email protected]>

* fix: net param name

---------

Co-authored-by: Jiajia-Cui <[email protected]>

* feat: add more ACs

* chore: typo

* feat: remove the maxQuantumAmount from reward cap

* feat: update asset unit

* chore: typo

* feat: update margin slippage in AMM

* chore: format

* feat: update margin formula

* feat: update ACs

* feat: market update ACs for mark price and perps price (#2171)

* feat: market update ACs for mark price and perps price

* feat: market update ACs for mark price and perps price

* feat: market update ACs for mark price and perps price

* feat: market update ACs for mark price and perps price

* feat: market update ACs for mark price and perps price

* feat: market update ACs for mark price and perps price

* chore: add ACs to feature.json file

---------

Co-authored-by: gordsport <[email protected]>

* refactor: AC clarifications

* refactor: amend 0012-NP-LIPE-005

* refactor: clarify and extend liquidation ACs

* refactor: additional clarifications

* feat: update fees on auction exit AC (#2173)

* feat: Add extra validator ranking reward metric AC (#2174)

* feat: Add extra validator ranking reward metric AC

Adds an extra validator ranking reward metric AC:

For reward metrics relating to trading, an individual must meet the staking requirement AND notional time-weighted average position requirement) set in the recurring transfer. If they do not then their reward metric is set to 0. Note, these requirements do not apply to the validator ranking metric or the market creation reward metric.

e.g. For a party that is a consensus or standby validator, the staking requirement and notional time-weighted average position requirement do not apply to their validator ranking metric

* chore: split AC into 3

* fix: remove old AC

* refactor: amend a few perp ACs

* chore: remove dup ac

* refactor: modify AC

* chore: update approbation now we have completed palazzo (#2184)

* chore: update approbation now we have completed palazzo

This updates the paths for approbation now that we have completed palazzo. The Approbation runs will now run against colosseo

* fix: milestone names

* Add spot ACs from cosmic (#2163)

* feat(acs): add spot acs from cosmic milestone

This adds All the spot ACs from the cosmic elevator milestone just before the feature was deferred.

* fix: remove LNL ACs

* fix: MD055 markdownlint errors

* fix: remove more LNL ACs

* fix: remove AC already correctly in 0037-OPEG (14 / 19)

* fix: delete duplicate AC copied from another spec

* fix: tidy up MKTD spot ACs

* fix: tidy up BTCH ACs for spot

* chore: add in an AC already covered in STs

* chore: mark spot ACs as stretch

* fix: linting

* chore: remove untestable ACs

* fix: AC coded number

* fix: remove old number

* chore: align features.json

* feat: market tick size

* feat: remove invalid price levels on tick size change

* Revert "feat: remove invalid price levels on tick size change"

This reverts commit a08bb51304e42d7cd9bee6cfb9dc1b7bc78175ec.

* feat: round price of orders pegged to mid

* chore: assign ac codes

* feat: clarify tick size specified in market decimals

* fix: features.json file after colosseo updates

* fix: Wording

* feat: add ac for taker fee cap

* chore: typo

* feat: add AC clarifying update logic

* chore: address comment

* chore: add features.json entry

* fix: syntax

* feat: add AC for validation

* chore: add new AC to features file

* feat: address comment

* feat: Add order spam (#2180)

* feat: Add order spam

Copies content from:

- https://github.com/vegaprotocol/specs/issues/2097

With base branch as Colosseo

* fix: add ACs to features.json

* Update 0062-SPAM-spam_protection.md

* fix: AC code error and MD lint

* Update protocol/0062-SPAM-spam_protection.md

Co-authored-by: David Siska <[email protected]>

* fix: quality checks

* Update 0062-SPAM-spam_protection.md

* chore: Update features.json

* fix: Update protocol/0062-SPAM-spam_protection.md

Co-authored-by: David Siska <[email protected]>

---------

Co-authored-by: Vegaklaus <[email protected]>
Co-authored-by: David Siska <[email protected]>

* chore: remove redundant AC

* fix: update correct features json

* fix: correct milestone name

* fix: missed merge from palazzo into colosseo (#2190)

This adds in the changes from https://github.com/vegaprotocol/specs/pull/2182

into colosseo and renumbers the new community tags ACs

* fix: closeout trades and auctions (#2189)

* fix: closeout trades and auctions

* fix: closeout trades and auctions

* chore: Add AC to features.json

* fix: closeout trades and auctions

* fix: closeout trades and auctions

---------

Co-authored-by: gordsport <[email protected]>

* feat: change direction of rounding pegged orders

* Revert "feat: change direction of rounding pegged orders"

This reverts commit 9d6ef32d3f8fb4ea4cb3895116f62fad64464c30.

* feat: cancel pegged orders

* chore: assign missing ac code

* feat: update formatting in formula

* chore: update formating

* feat: update parameter of each transfer

* fix: remove for now order spam (#2196)

* fix: remove for now order spam

* fix: remove for now order spam

* fix: formatting

* chore: markdown

* feat: composite price methodology (#2200)

* feat: composite price methodology

copies change from palazzo #2197 into Colosseo

* fix: markdown linting

---------

Co-authored-by: David Siska <[email protected]>

* chore: clearer ac

* chore: fix ac typo

* Fix/dont update book price in auction (#2201)

* fix: don't include book price during auctions

* fix: don't include book price during auctions

* fix: don't include book price during auctions

* fix: don't include book price during auctions

* WIP: Collat decrease ACs (#2178)

* refactor: split cross and isolated margin cases

* refacgtor: further clarification

---------

Co-authored-by: Gordsport <[email protected]>

* fix: Wording for iceberg testing (#2194)

* feat: add validation on risk factor during isolated margin

* feat: add linear slippage factor

* feat: add AC code for isolated margin validation change (#2207)

Adds AC code for isolated margin validation change

* chore: remove ac error never raised

* chore: remove ac from features

* feat: removal of checkpoint (#2146)

* feat: add ac for price via data node

* feat: removal of checkpoint

It has been decided that the checkpoint (LNL) feature will be removed from the core as this is no longer a viable option for restarting the network.

In its place will be snapshots and any required tooling.

When reviewing this PR please take a look at the following issues (specifically the QA issue):

- https://github.com/vegaprotocol/system-tests/issues/3346
- https://github.com/vegaprotocol/vega/issues/10506

* fix: missing net para name

---------

Co-authored-by: Jiajia-Cui <[email protected]>
Co-authored-by: David Siska <[email protected]>

* feat: add AC 209 for margin factor being greater than 1

* fix: Update price trigger limit from 5 to 100 (#2210)

* chore: remove 0043-MKTL-005

* feat: update wording for spot ac

* chore: remove one word

* fix: md lint

* fix: Updating wording

* Add ACs for new asset bridge (#2204)

* feat: add initial deposit withdraw ACs

* fix: AC code numbering

* fix: spelling

* feat: update VCBS spec for second bridge and add an AC

* feat: add an official section on issuing signatures to update the multisig contract

* feat: a couple more AC's

* chore: typos

* chore: fix markdown

* chore: add new ACs to features.json file

* fix: quality checks

* fix: duplicate AC number

* Update protocol/0069-VCBS-validators_chosen_by_stake.md

* feat: add AC's for second bridge asset proposals

* feat: add AC for swapping an asset between chains through a spot market

* feat: add another API AC for the multisig add/remove bundles

* fix: approbation number errors

* fix: more quality checks

* fix: syntax

* chore: add AC to doubly check we can stop both bridges

* fix: clarifications

* fix: small edits

* fix: reword ACs to not specify a single bridge

* fix: spelling

* fix: wording and add ACs to features file

* fix: spellling

* Fix: AC code

* Update protocol/0027-ASSP-asset_proposal.md

Co-authored-by: David Siska <[email protected]>

* Update protocol/0027-ASSP-asset_proposal.md

Co-authored-by: David Siska <[email protected]>

* Update protocol/0027-ASSP-asset_proposal.md

Co-authored-by: David Siska <[email protected]>

* Apply suggestions from code review

Co-authored-by: David Siska <[email protected]>

* chore: add AC codes to features file

* Apply suggestions from code review

Co-authored-by: David Siska <[email protected]>

* fix: MD lint

* Update protocol/0069-VCBS-validators_chosen_by_stake.md

Co-authored-by: David Siska <[email protected]>

* fix: MD linting

* Update protocol/0069-VCBS-validators_chosen_by_stake.md

Co-authored-by: wwestgarth <[email protected]>

---------

Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>

* fix: Updating wording for self trading states

* chore: correct a typo in spec 0068 (#2216)

* fix: remove 0044-LIME-074 as its not for spot (#2217)

Removes 0044-LIME-074 as its not for spot

* fix: add missing AC regarding the rewards.team.minEpochsInTeam netparam (#2220)

Adds an AC to ensure that the `rewards.team.minEpochsInTeam` is adhered to when team members become eligible for rewards

* chore: Add AC for vega issue #10973 (#2221)

* chore: Add AC for vega issue #10973

Adds and AC for the vegaprotocol/vega#10973 issue seen on testnet

* fix: add to features.json

* fix: json syntax

* fix: update ac description (#2222)

* feat: update 0041-TSTK

* feat: update 0042-LIQF

* feat: update 0044-LIME

* feat: update 0014-ORDT

* feat: update 0080-SPOT

* feat: apply feedback from review

Co-authored-by: Jiajia-Cui <[email protected]>

* Feat/liq strat range (#2218)

* feat: liquidation explicit range

* feat: liquidation explicit range

* feat: liquidation explicit range

* feat: liquidation explicit range

* feat: liquidation explicit range

* feat: liquidation explicit range

* fix: witold's correction

Co-authored-by: Witold <[email protected]>

* fix: include price mon into disc

---------

Co-authored-by: Witold <[email protected]>

* chore: add AC codes

* fix: duplicate numbers

* fix: AC numbering

* fix: AC number dupes

* fix: json syntax

* chore(refactor): reorder features.json file (#2224)

Reorders the features.json file for better reporting

* feat: update validation on market and position decimals

* feat: address comment on spot

* feat: add paragraph for validation

* feat: address comments

* chore: update 0069-VCBS-094, validator key treated like any other for spam on the multisig thing (#2223)

* chore: markdown

* feat: update AC in json

* feat: remove prevision from ACs

* feat: address comment

Co-authored-by: David Siska <[email protected]>

* feat: address comment on AC 022

Co-authored-by: David Siska <[email protected]>

* feat: address comment on AC 023

Co-authored-by: David Siska <[email protected]>

* feat: address comment on AC 025

Co-authored-by: David Siska <[email protected]>

* chore: markdown

* chore: typo

* refactor: modify auction margin in cross-margin mode

* Fix/lps vote without staked vega (#2228)

* fix: LPs can vote on their market without gov token

* fix: LPs can vote on their market without gov token

* fix: LPs can vote on their market without gov token

* feat: allow negative relative pnl to receive rewards

* feat: add clarification for offseting negative scores

* feat: update AC FTCO-001 and 005

* feat: add specific AC for negative pnl case

* fix: clarify total fees (#2237)

* feat: address comment

* feat: tidy up

* feat: tidy marginal cost ACs

* feat: couple nice to have acs

* chore: clarify offset logic

* feat: add realised returns metric

* chore: fix realised typo

* chore: fix checks

* feat: add clarification for short positions

* chore: remove invalid stop AC

* feat: add AC for position decimal in spot market

* feat: update json file

* chore: add more acceptance criteria

* feat: publish interim reward data

* fix: updates for checks

* chore: restrict update frequency by network parameter

* chore: renumber AC codes

* feat: couple more spot acs

* feat: add transfer interval field

* feat: lock funds for scheduled transfer

* feat: make locking behaviour consistent

* feat: add clarification for reward caps and ACs

* chore: remove locked funds requirement

* chore: move transfer interval to dispatch strategy

* chore: remove reference to interim data

* chore: revert removal of clarification

* chore: fix markdownlint

* feat: add ACs to cover market order collateral check for spot market

* chore: add acs for testing rewards from spot markets

* feat: add AC 026027028

* feat: add ACs to json file

* chore: typo

* feat: address comment from Charlie

* feat: update AC code

* feat: add spec for when market is stuck in opening auction

* chore: tidy up

* chore: update json file

* feat: address comment

Co-authored-by: David Siska <[email protected]>

* chore: align interim reward information spec with implementation

* chore: align acs with core

* chore: add additional ACs for validating pegged orders

* chore: markdownlint

* fix: remove magic defaults

Signed-off-by: Elias Van Ootegem <[email protected]>

* chore: merge master into colosseo and resolve conflicts (#2300)

* User interface: add Post only and Reduce only (#1640)

* draft for SORD

* add AC for showing rejected reason

* typo

* execution flags on orders table

* add codes to SORD

* Update user-interface/7002-SORD-submit_orders.md

Co-authored-by: candida-d <[email protected]>

* add link to docs

---------

Co-authored-by: candida-d <[email protected]>

* Clarify rewards if multisig contains a key it should not (#1643)

* Clarify rewards if multisig contains a key it should not

* fix: MD lint error

---------

Co-authored-by: gordsport <[email protected]>

* feat: update FOK MO reduce-only

* fix: Add some more cancel order ACs.

* Update protocol/0033-OCAN-cancel_orders.md

Co-authored-by: Tom <[email protected]>

* feat: Add a test for checking performance scores when checkpoint rest… (#1637)

* feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch.

* fix: Typo.

* chore: Fix indentation (tabs/spaces).

* feat: Add a test for checking performance scores when checkpoint rest… (#1637)

* feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch.

* fix: Typo.

* chore: Fix indentation (tabs/spaces).

* Update 0069-VCBS-validators_chosen_by_stake.md (#1653)

Deleted half an AC as discussed on slack (as the number for the performance score didn't make sense here)

* Amend price monitoring ACs (#1660)

* refactor: update ACs

* chore: tell approbation to leave me alone

* chore: try again

* refactor: rephrase AC

* refactor: clarify

* refactor: fix spelling

* feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history (#1659)

* feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history

* fix: spell checker

---------

Co-authored-by: gordsport <[email protected]>
Co-authored-by: Gordsport <[email protected]>

* spec: draft for time-based mempool pruning (#1645)

* spec: draft for time-based mempool pruning

Signed-off-by: Elias Van Ootegem <[email protected]>

* spec: spelling

Signed-off-by: Elias Van Ootegem <[email protected]>

* Spelling + clarify how block height is determined

Signed-off-by: Elias Van Ootegem <[email protected]>

* spec: add some additional ACs, remove mention of TxV4, clarify that transaction data includes block hash in addition to block height

Signed-off-by: Elias Van Ootegem <[email protected]>

* complete acceptance criteria

Signed-off-by: Elias Van Ootegem <[email protected]>

* fix typo

Signed-off-by: Elias Van Ootegem <[email protected]>

---------

Signed-off-by: Elias Van Ootegem <[email protected]>
Co-authored-by: Gordsport <[email protected]>

* re-word ac

* chore: Add decision notes template (#1658)

* chore: Add decision notes template

Added a decision template based loosely on the [Any Decision Records](https://adr.github.io/madr/) template

Also updated some MD linting to allow sibling duplicated header titles and double spacing to make reading easier.

* fix: Spelling error

* feat: update for distributing remainder of liq fee

* fix: correct AC

* refactor: address feedback

* add spec for current collateral

* clarify total margin available

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* add asset file

* Add ACs for asset detail dialog and link up with collateral spec

* add suggested sort order per account type

* fix: 005 AC code link (#1671)

* fix: mempool pruning with PoW only

* fix: linting errors

* refactor: add liquidation price estimate

* refactor: add ACs

* refactor: another AC

* refactor: cosmetic change

* Update 0045-DSRC-data_sourcing.md (#1674)

* Update 0045-DSRC-data_sourcing.md

* Update 0045-DSRC-data_sourcing.md

* Wording of timestamp AC

---------

Co-authored-by: AnExsomnis <[email protected]>
Co-authored-by: Barney Mannerings <[email protected]>

* add spec for current functionality fo fills data grid

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* Make notional value of feels a could

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* add clarification on user role for trades during continuos vs auction

* fix: typo in ac number

* feat: update typo in 0061

* feat: add explaination on ersatz validators

* feat: correct typos

* feat: typo

* Update user-interface/7005-FILL-fills.md

* add browser wallet spec as part of approbation set up

* chore: fix typo and add browser specs to app.json

* chore: add browser wallet to categories, hopefully in the right place

* chore: Update 0033-OCAN-cancel_orders.md (#1686)

* feat: update BRIE specs (#1654)

* feat: update BRIE specs

Signed-off-by: Jeremy Letang <[email protected]>

* chore: update spelling and linting

* feat: update BRIE specs

Signed-off-by: Jeremy Letang <[email protected]>

* chore: update spelling and linting

* fix: spelling and lint and rebase

* fix: spelling

---------

Signed-off-by: Jeremy Letang <[email protected]>
Co-authored-by: gordsport <[email protected]>
Co-authored-by: Gordsport <[email protected]>

* chore: Update cosmic elevator branch from master (#1688)

* refactor: let max oi drop during auciton

* fix: duplicate AC codes in 0069-VCBS (#1536) (#1537)

* Update `cosmicelevator` branch from `master` branch (#1550)

* fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation

* fix: duplicate AC codes in 0069-VCBS (#1536)

* chore: trailing spaces

* fix: remove the unused netparam; not liking that

* chore: remove untestable AC from 0018 (#1530)

* chore: reword 0063-VALK-013

* Update 0035-LIQM-liquidity_monitoring.md (#1539)

* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md

* fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)

* Update 0011-NP-CLIE-client-interaction-tests.md

* feat: allow any key to request multisg signers update bundle

* feat: clarify spam status

* refactor: let max oi drop during auciton

* Wording tweaks for spam protection spec (#1548)

* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section

Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: Paul Webb <[email protected]>
Co-authored-by: RomanLeca <[email protected]>
Co-authored-by: Witold <[email protected]>
Co-authored-by: candida-d <[email protected]>

* Update cosmicelevator branch from master to keep up-to-date (#1560)

* fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation

* fix: duplicate AC codes in 0069-VCBS (#1536)

* chore: trailing spaces

* fix: remove the unused netparam; not liking that

* chore: remove untestable AC from 0018 (#1530)

* chore: reword 0063-VALK-013

* Update 0035-LIQM-liquidity_monitoring.md (#1539)

* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md

* fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)

* Update 0011-NP-CLIE-client-interaction-tests.md

* feat: allow any key to request multisg signers update bundle

* feat: clarify spam status

* refactor: let max oi drop during auciton

* Wording tweaks for spam protection spec (#1548)

* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section

* fix spelling in spam protection spec (#1553)

* Update 0069-VCBS-validators_chosen_by_stake.md

Added pending validator to VCBS-59

* Update 0069-VCBS-validators_chosen_by_stake.md

Clarification on 0059

* Update 0062-SPAM-spam_protection.md

* Update 0062-SPAM-spam_protection.md

fixed link to defaults.go

* Add quality checks to the makefile (#1556)

* fix: broken links in the specs (#1557)

* fix: remove broken kraken link

---------

Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: Paul Webb <[email protected]>
Co-authored-by: RomanLeca <[email protected]>
Co-authored-by: Witold <[email protected]>
Co-authored-by: candida-d <[email protected]>
Co-authored-by: Vegaklaus <[email protected]>

* chore: Update cosmicelevator from master branch (#1564)

* fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation

* fix: duplicate AC codes in 0069-VCBS (#1536)

* chore: trailing spaces

* fix: remove the unused netparam; not liking that

* chore: remove untestable AC from 0018 (#1530)

* chore: reword 0063-VALK-013

* Update 0035-LIQM-liquidity_monitoring.md (#1539)

* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md

* fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)

* Update 0011-NP-CLIE-client-interaction-tests.md

* feat: allow any key to request multisg signers update bundle

* feat: clarify spam status

* refactor: let max oi drop during auciton

* Wording tweaks for spam protection spec (#1548)

* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section

* fix spelling in spam protection spec (#1553)

* Update 0069-VCBS-validators_chosen_by_stake.md

Added pending validator to VCBS-59

* Update 0069-VCBS-validators_chosen_by_stake.md

Clarification on 0059

* Update 0062-SPAM-spam_protection.md

* Update 0062-SPAM-spam_protection.md

fixed link to defaults.go

* Add quality checks to the makefile (#1556)

* fix: broken links in the specs (#1557)

* fix: remove broken kraken link

* refactor: clarify 0042-LIQF-018

* feat: fix non-protocol linting and add makefile (#1563)

* feat: fix non-protocol linting and add makefile

* fix: remove binary file

* fix: remove binary

* fix: revert ui changes

* fix: remove package files

* Update glossaries/distributed-ledger-glossary.md

---------

Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: Paul Webb <[email protected]>
Co-authored-by: RomanLeca <[email protected]>
Co-authored-by: Witold <[email protected]>
Co-authored-by: candida-d <[email protected]>
Co-authored-by: Vegaklaus <[email protected]>

* chore: Update cosmicelevator branch from master (#1573)

* docs: post only orders (#1562)

* docs: Adding specs for post-only orders

* Update from master (#1602)

* fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation

* fix: duplicate AC codes in 0069-VCBS (#1536)

* chore: trailing spaces

* fix: remove the unused netparam; not liking that

* chore: remove untestable AC from 0018 (#1530)

* chore: reword 0063-VALK-013

* Update 0035-LIQM-liquidity_monitoring.md (#1539)

* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md

* fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)

* Update 0011-NP-CLIE-client-interaction-tests.md

* feat: allow any key to request multisg signers update bundle

* feat: clarify spam status

* refactor: let max oi drop during auciton

* Wording tweaks for spam protection spec (#1548)

* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section

* fix spelling in spam protection spec (#1553)

* Update 0069-VCBS-validators_chosen_by_stake.md

Added pending validator to VCBS-59

* Update 0069-VCBS-validators_chosen_by_stake.md

Clarification on 0059

* Update 0062-SPAM-spam_protection.md

* Update 0062-SPAM-spam_protection.md

fixed link to defaults.go

* Add quality checks to the makefile (#1556)

* fix: broken links in the specs (#1557)

* fix: remove broken kraken link

* refactor: clarify 0042-LIQF-018

* feat: fix non-protocol linting and add makefile (#1563)

* feat: fix non-protocol linting and add makefile

* fix: remove binary file

* fix: remove binary

* fix: revert ui changes

* fix: remove package files

* Update glossaries/distributed-ledger-glossary.md

* Update 0069-VCBS-validators_chosen_by_stake.md

Added ACs to match the implementation so its codified (i.e., if an Ersatzvalidator drops below ownstake and there's no-one there to replace it, it is not demoted to pending.

* Update 0069-VCBS-validators_chosen_by_stake.md

* fix: Update acceptance criteria to correctly reflect implementation (#1549)

Co-authored-by: Gordsport <[email protected]>

* fix: update epoch ACs (#1555)

Co-authored-by: Gordsport <[email protected]>

* feat: update 0042, LP fee Transfer, Distribution

* Add build folder to gitigore

The approbation checks in `makefile` use this folder. Make sure it's not checked in.

* Update protocol/0042-LIQF-setting_fees_and_rewarding_lps.md

Co-authored-by: David Siska <[email protected]>

* Ignore dictionary

Spellcheck creates a dictionary file. Ensure it isn't committed.

* Un parallelise clone-sources in makefile

The makefile tried to be clever and run all the remote-repo clones for Approbation checks in parallel. Due to my limited makefile skills, the check could run before a clone was finished. Run them in series instead.

This also improves the output a little

* Add specs param to names and codes in makefile

The old behaviour (default paths) should have been deprecated ages ago, but hasn't been. This change makes it provide the same paths as the defaults.

* feat: update maker fee transfer account

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update protocol/0029-FEES-fees.md

Co-authored-by: David Siska <[email protected]>

* Update protocol/0029-FEES-fees.md

Co-authored-by: David Siska <[email protected]>

* Update protocol/0029-FEES-fees.md

Co-authored-by: David Siska <[email protected]>

* Update 0048-DSRI-data_source_internal.md

* fix: refactor 0069-VCBS-052 (#1570)

Co-authored-by: Gordsport <[email protected]>
Co-authored-by: Vegaklaus <[email protected]>

* fix: MD and spelling lint checks

* fix: MD and spelling lint errors

* fix: update wording for AC 0059-VCBS-016- (#1566)

* Update 0062-SPAM-spam_protection.md (#1571)

* Update 0062-SPAM-spam_protection.md

* Update protocol/0062-SPAM-spam_protection.md

* Update protocol/0062-SPAM-spam_protection.md

---------

Co-authored-by: Gordsport <[email protected]>

* Update 0011-NP-CLIE-client-interaction-tests.md (#1542)

* Update 0011-NP-CLIE-client-interaction-tests.md

Added ACs to test static spam protection (wallet doesn't allow you to get banned)

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update 0011-NP-CLIE-client-interaction-tests.md

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update non-protocol-specs/0011-NP-CLIE-client-interaction-tests.md

Co-authored-by: Gordsport <[email protected]>

* Update 0011-NP-CLIE-client-interaction-tests.md

* Update 0011-NP-CLIE-client-interaction-tests.md

* chore: fix spelling and MD lint checks

---------

Co-authored-by: Gordsport <[email protected]>
Co-authored-by: gordsport <[email protected]>

* Update 0011-NP-CLIE-client-interaction-tests.md (#1579)

* refactor: clarify AC

* fix: adding bound on slippage part of margin

* fix: adding bound on slippage part of margin - ACs

* chore: lint

* chore: format

* chore: add ac codes

* chore: lint

* feat: make it nonlinear

* fix: remove obsolete ac

* fix: typo

* fix: typo from comments

Co-authored-by: Tom <[email protected]>

* fix: code block in list formatting (#1584)

* chore: Remove untestable acceptance criteria

* feat: add rate limit spec

* Update 0057-TRAN-transfers.md (#1588)

* Update 0057-TRAN-transfers.md

* Update 0057-TRAN-transfers.md

* chore: add AC codes

* Update 0057-TRAN-transfers.md (#1590)

* Update 0069-VCBS-validators_chosen_by_stake.md

Added Acs for IssueSignature

* Update 0069-VCBS-validators_chosen_by_stake.md

* fix: Expand acceptance criteria to make them clear for 0011-NP-CLIE-client-interaction (#1585)

* fix: Expand acceptance criteria to make them clear

* chore: Fix formatting

* fix: Address review comments

---------

Co-authored-by: Paul Webb <[email protected]>

* feat: Add new PLUP AC for state-sync in protocol upgrade.

* feat: add closeout API

* chore: tidy up

* chore: remove blank line

* chore: by more specific about when a client should be banned

* feat: update formula line 140

* fix: Add extra cases for various things that might be affected by validators joining and leaving.

* fix: Review comments for new ACs.

* fix: Satisfy the linter.

* refactor: add slippage to orders

* refactor: update examples

* chore: fix linter issues

* refactor: fix typo

* refactor: formlise margin level treatment

* refactor: amend/add ACs

* Update 0042-LIQF-setting_fees_and_rewarding_lps.md (#1598)

* Update 0042-LIQF-setting_fees_and_rewarding_lps.md

* fix: linting errors

---------

Co-authored-by: Gordsport <[email protected]>
Co-authored-by: gordsport <[email protected]>

* fix: linting error

* fix: MD lint and spelling

* Update 0069-VCBS-validators_chosen_by_stake.md (#1604)

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* Update 0069-VCBS-validators_chosen_by_stake.md

* fix: MD linting and spelling errors

---------

Co-authored-by: gordsport <[email protected]>

* Update 0069-VCBS-validators_chosen_by_stake.md (#1596)

* Update 0069-VCBS-validators_chosen_by_stake.md

* fix: spelling errors

---------

Co-authored-by: Gordsport <[email protected]>
Co-authored-by: gordsport <[email protected]>

* fix: More validator join/leave test cases involving checkpoints. (#1601)

* fix: More validator join/leave test cases involving checkpoints.

* fix: spelling error

* fix: Update AC codes to not be duplicates.

---------

Co-authored-by: gordsport <[email protected]>
Co-authored-by: Gordsport <[email protected]>

* feat: update make file and add approabtion to CI (#1605)

* feat: update make file and add approabtion to CI

* chore: add more checks and fix errors

* fix: checkout PR branch

* fix: get branch

* fix: approbation errors

---------

Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: Paul Webb <[email protected]>
Co-authored-by: RomanLeca <[email protected]>
Co-authored-by: Witold <[email protected]>
Co-authored-by: candida-d <[email protected]>
Co-authored-by: Vegaklaus <[email protected]>
Co-authored-by: MuthuVega <[email protected]>
Co-authored-by: AnExsomnis <[email protected]>
Co-authored-by: Jiajia-Cui <[email protected]>
Co-authored-by: Edd <[email protected]>
Co-authored-by: Jiajia-Cui <[email protected]>
Co-authored-by: claudiumilea <[email protected]>
Co-authored-by: Tom <[email protected]>
Co-authored-by: MuthuVega <[email protected]>
Co-authored-by: Philip Scott <[email protected]>
Co-authored-by: Philip Scott <[email protected]>
Co-authored-by: Jake Bennett <[email protected]>

* fix: lint errors and duplicate paragraph (#1630)

* fix: lint errors and duplicate paragraph

* fix: MD lint error

* Chore: Update cosmicelevator from master (#1646)

* feat: Add new cases, mostly around eth changes during outages. A few extra cases for PUP.

* chore: Linting fixes.

* fix: More linting issues.

* fix: spelling and AC code lint errors

* fix: spelling

* feat: Clarifying fees paid (or not paid) by post-only orders (#1635)

* chore: remove invalid and unimplemented use cases

* refactor: floor slippage

* User interface: add Post only and Reduce only (#1640)

* draft for SORD

* add AC for showing rejected reason

* typo

* execution flags on orders table

* add codes to SORD

* Update user-interface/7002-SORD-submit_orders.md

Co-authored-by: candida-d <[email protected]>

* add link to docs

---------

Co-authored-by: candida-d <[email protected]>

* Clarify rewards if multisig contains a key it should not (#1643)

* Clarify rewards if multisig contains a key it should not

* fix: MD lint error

---------

Co-authored-by: gordsport <[email protected]>

---------

Co-authored-by: Jake Bennett <[email protected]>
Co-authored-by: Tom <[email protected]>
Co-authored-by: Rado <[email protected]>
Co-authored-by: Witold <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: candida-d <[email protected]>
Co-authored-by: David Siska <[email protected]>

---------

Co-authored-by: Witold <[email protected]>
Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: Paul Webb <[email protected]>
Co-authored-by: RomanLeca <[email protected]>
Co-authored-by: candida-d <[email protected]>
Co-authored-by: Vegaklaus <[email protected]>
Co-authored-by: Tom <[email protected]>
Co-authored-by: MuthuVega <[email protected]>
Co-authored-by: AnExsomnis <[email protected]>
Co-authored-by: Jiajia-Cui <[email protected]>
Co-authored-by: Edd <[email protected]>
Co-authored-by: Jiajia-Cui <[email protected]>
Co-authored-by: claudiumilea <[email protected]>
Co-authored-by: MuthuVega <[email protected]>
Co-authored-by: Philip Scott <[email protected]>
Co-authored-by: Philip Scott <[email protected]>
Co-authored-by: Jake Bennett <[email protected]>
Co-authored-by: Rado <[email protected]>
Co-authored-by: Michael <[email protected]>

* fix: fix prefix for browser wallet

* chore: fixed wrong file..

* chore: now undo my formatting for the other file

* chore: undo formatting change

* add missing AC

* add more ac

* typoe

* chore: add ac for the sprint

* add ui specs for finding closed markets

* fix number sequence

* chore: add acs for market selector

* chore: added ACs for transaction log

* chore: removed navigation AC

* add key pair ac that slipped the net via a ticket going straight to the done column

* Add UI ACs for network and nodes (#1700)

* Update 0002-WCON-connect_vega_wallet.md

Removing all coulds, shoulds and would like tos. These are captured here and will be pulled into tickets as applicable later down the line if / when these features are implemented

* Update user-interface/0002-WCON-connect_vega_wallet.md

Co-authored-by: Penny Andrews <[email protected]>

* add settings ac

* Update user-interface/1101-BWAL-browser_wallet.md

* remove ac for recovery phrase and add new connection and transaction ac when not onboarded

* add ac

* add and increment

* chore: update readme (#1709)

Co-authored-by: peterbarrow <[email protected]>

* feat: typo

* chore(trading): Add transfer ACs

* chore(trading): Add transfer ACs number fix

* chore: update proposal acs

* fix(trading): Fix transfer specs ID

* added all markets and proposal markets ACs

* Fix: bring ersatz number in line with core.

* increment and add ac

* format

* rework

* chore: withdraw minimal amount

* chore: add new market proposal acs

* Update 1101-BWAL-browser_wallet.md

Removed: 

- It is visually similar to other transaction types but essentially has less of the human readable detail(s) (design note) (1101-BWAL-057) as it is a design note

- When I approve a transaction I can see confirmation that the transaction has been approved (1101-BWAL-045) - separate story in backlog


- When I reject a transaction I can see confirmation that the transaction has been rejected (1101-BWAL-049) - separate story in backlog

* chore:update todo

* amend spec numbers

* update acs

* update numeration

* 6501-ASSE-assets.md

* add ac for import wallet

* add list connections ac

* update acs

* A community settlement story.

* fix: another AC for changing oracle after trading termination

* fix: another AC for changing oracle after trading termination

* chore: ACs added to 6002-MDET-market-details

* chore: few more details added

* Update user-interface/6002-MDET-market-details.md

Co-authored-by: daro-maj <[email protected]>

* chore: info about tooltips added

* Update user-interface/6002-MDET-market-details.md

Co-authored-by: Ben <[email protected]>

* liquidity ACs

* updated numeration

* chore(trading): Add Position ACs (#1733)

* chore(trading): Add Position ACs

* chore: pr suggestion

* remove outdated ac

* update

* chore: add AC for quantum formatting

* chore: fix bold typo

* chore: filled ACs in 6003-ORDB

* disconnect ac

* finger slip

* test: market selector acs update

* update console space

* chore: remove cosmic feature from master (#1766)

There has been some confusion when designing FE/UXs as the spec for governance transfers has changed slightly from whats in master.

Its also the case that master should now be what is live in mainnet this feature is not one that is live.

* chore: 6005-THIS-trade_history filled with ACs

* popout windoiw

* fix: clarify what's a market and what's a network param.

* fix: clarify what's a market and what's a network param.

* fix: clarify what's a market and what's a network param.

* fix: typo

Co-authored-by: Gordsport <[email protected]>

* add browser wallet loading state ACs

* chore: add AC for the button always being disabled (#1746)

* Update 5002-LIQP-liquidity.md with 5002-LIQP-013 (#1769)

* user-interface/

* depth chart ACs

* update acs

* update numbers

* update name of reference

* update

* re-arrange browser wallet acs to save mainetenance (#1781)

* re-arrange ac to save mainetenance

* add file extension

* onboarding spec tweak

* final tweaks and removals

* add specs to categories and apps

---------

Co-authored-by: Dexter Edwards <[email protected]>

* chore(trading): 6004-CHAR-chart ACs created (#1775)

* chore(trading): fix spec links

* chore(trading): add code to apps.json

* chore(trading): fix numbering

* chore(trading): fix Char having duplicated id

* chore(trading): fix id duplication

* chore)trading): Fixing missed 0

* feat: use ghcr image to run approbation

* feat: fix flags

* fix: descriptions

* chore(trading):add chart and orderbook ACs

* add telemtry ac

* update ac description

* remove browser wallet

* update README

* Update 0036-BRIE-event_queue.md

Added clarification on event forwarding

* stop orders acs (#1859)

* Update 6002-MDET-market-details.md

Add some market successor specs

* feat: fix some specs

* Closed market list changes (#1828)

* chore: remove spec on showing user pnl in closed market list

* chore: add successor market acs

* chore: update data display for mark price, liquidation price and pnl

* `DATA`. Quantum decimals and accounts (#1512)

* add more synonyms

* introduce accounts

* accounts are displayed as asset balances

* introduce quantum

* fix links to old DATA file

* more detail

* typo

Co-authored-by: Edd <[email protected]>

---------

Co-authored-by: Edd <[email protected]>

* chore: add acs for network upgrade proposal (#1857)

* chore: add acs for network upgrade proposal

* chore: add acs for proposal enhancements

* chore: proposal acs

* chore: acs for successor market

* Update  the GitHub action token add_issue_new_projects.yml

* chore: remove user-interface specs (#1877)

* fix: add 048-COSMICELEVATOR-009

* fix: reword 0045-DSRC-012

* chore: Merge cosmic into master (#2028)

* feat: Adding generic AC for perp order types (#1908)

* feat: Adding generic AC for perp order types

* refactor: clarify network parameter behaviour

* feat: add acceptance criteria for program updates

* feat: update features

* fix spellcheck

* fix: mkt param to be a netparam

* refactor: update spelling as per feedback

Co-authored-by: Tom <[email protected]>

* feat: add vesting spec

* feat: add activity spec

* feat: update reward distribution

* feat: address vesting feedback

* feat: update reward metrics

* feat: add validator power metric

* feat: add new entity scoping

* refactor: linting and spellcheck fixes

* refactor: address network param feedback

* refactor: fix formatting

* feat: update the validator ranking metric

* fix: correct variable name

* feat: add vested multiplier

* feat: change total rewards calc as per feedback

* feat: remove logarithmic functions

* refactor: rename open-interest metric to position metric

* fix: fix linting and spellcheck

* feat: add validation for k

* feat: address feedback

Co-authored-by: David Siska <[email protected]>

* feat: address exponential feedback

Co-authored-by: David Siska <[email protected]>

* feat: switch rank exponential distribution to table

* feat: address feedback

* feat: apply suggestion

Co-authored-by: Barnaby M <[email protected]>

* feat: add limits

* feat: clarify requirements not applied for certain metrics

* feat: switch reward accounts to per unique transfer

* refactor: clarification of lock period

* feat: address comments

* feat: address comments

* feat: update json file

* feat: remove 061062

* feat: typo

* feat: formatting

* feat: update format for formula

* feat: Update AC 080

Co-authored-by: David Siska <[email protected]>

* feat: update space

* Update protocol/0042-LIQF-setting_fees_and_rewarding_lps.md

Co-authored-by: David Siska <[email protected]>

* feat: typo

Co-authored-by: David Siska <[email protected]>

* feat: typo

Co-authored-by: David Siska <[email protected]>

* feat: address comments

* feat: benefit factors set by original referral set

* feat: add reward multipliers for staking

* refactor: rename maxBenefitTiers to maxReferralTiers

* fix: update referral codes

* refactor: address review comments

* fix: correct equation for converting to quantum

* feat: align with core implementation

* feat: update market parameter part

* feat: Adding perp margin calcs (#1915)

* feat: Adding perp margin calcs

* fixed: removed one ac

* fix: ac numbers

* fix: add quote

* Update 0044-LIME-lp_mechanics.md (#1918)

SLA remove 0044-LIME-010

* chore: Delete incorrect acceptance criteria relating to perps and market termination

* chore: Update features.json to reflect removed ac

* feat: update ACs in 0034

* feat: update AC code

* fix: appprobation from pr#1921

* fix: features.json for PR 1921 (#1924)

Updates the features.json as pt2 of #1921 .

* Update 0044-LIME-lp_mechanics.md (#1925)

* refactor: bring specs in line with implementation

* refactor: remove undelegate in anger

* refactor: add `0` account bit

* refactor: general -> global

* refactor: address comments from PR review

* refactor: review suggestion

Co-authored-by: David Siska <[email protected]>

* refactor: clarify details around `0` account

* feat: update AC 0044-LIME-028

* Update protocol/0044-LIME-lp_mechanics.md

Co-authored-by: David Siska <[email protected]>

* refactor: remove redundant sentences

* Update protocol/0044-LIME-lp_mechanics.md

Co-authored-by: David Siska <[email protected]>

* Update protocol/0044-LIME-lp_mechanics.md

Co-authored-by: David Siska <[email protected]>

* addressed comments

* chore: add two eth oracles ACs related to multiple contracts (#1926)

* chore: add two eth oracles ACs related to multiple contracts

* fix: Update protocol/0082-ETHD-ethereum-data-source.md

---------

Co-authored-by: Gordsport <[email protected]>

* modified for clarity and consistency

* chore: tidy up the features.json file (#1929)

* fix: reword ACs 38, 39 (#1923)

Co-authored-by: Gordsport <[email protected]>

* test: add a concrete example

* fix: Spot ACs in features.json file (#1931)

* fix: Spot ACs in features.json file

moves the spot related SLA ACs into the spot feature for tracking

* fix: dupes

* feat: update AC 0044-LIME-026

* feat: update AC

Co-authored-by: David Siska <[email protected]>

* fix: Minor spelling corrections, plus two new ACs for testing perp data is visible in REST and GRPC.

* fix: logic fix

* fix: align AC with implementation

* Fix/fee calc step is netparam (#1937)

* fix: fee distribution time step is a netparam

* fix: fee distribution time step is a netparam

* fix: fee distribution time step is a netparam

* fix: fee distribution time step is a netparam

---------

Co-authored-by: Paul Webb <[email protected]>

* fix: revert the deployment name changes in the features.json file (#1943)

* fix: align with core

* fix: small correction

* fix: Add tests for perpetuals doing protocol upgrade, checkpoint and network history. (#1940)

Co-authored-by: Gordsport <[email protected]>

* chore: add AC codes to referral ACs in fees spec (#1947)

* chore: add AC codes to referral ACs in fees spec

* chore: add Codes

* refactor: move acs to correct section

* feat: align acs with implementation

* fix: remove legacy ac

* chore: move batch transfers out of deployment 2 (#1948)

* refactor: amend margin formula

* feat: add clarification when no indicative price

* fix/enacted doesn't mean leaves opening auction

* fix: remove mentions of maturity

* Update comsic from master (#1956)

* refactor: floor slippage

* User interface: add Post only and Reduce only (#1640)

* draft for SORD

* add AC for showing rejected reason

* typo

* execution flags on orders table

* add codes to SORD

* Update user-interface/7002-SORD-submit_orders.md

Co-authored-by: candida-d <[email protected]>

* add link to docs

---------

Co-authored-by: candida-d <[email protected]>

* Clarify rewards if multisig contains a key it should not (#1643)

* Clarify rewards if multisig contains a key it should not

* fix: MD lint error

---------

Co-authored-by: gordsport <[email protected]>

* feat: update FOK MO reduce-only

* fix: Add some more cancel order ACs.

* Update protocol/0033-OCAN-cancel_orders.md

Co-authored-by: Tom <[email protected]>

* feat: Add a test for checking performance scores when checkpoint rest… (#1637)

* feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch.

* fix: Typo.

* chore: Fix indentation (tabs/spaces).

* feat: Add a test for checking performance scores when checkpoint rest… (#1637)

* feat: Add a test for checking performance scores when checkpoint restart happens in a new epoch.

* fix: Typo.

* chore: Fix indentation (tabs/spaces).

* Update 0069-VCBS-validators_chosen_by_stake.md (#1653)

Deleted half an AC as discussed on slack (as the number for the performance score didn't make sense here)

* Amend price monitoring ACs (#1660)

* refactor: update ACs

* chore: tell approbation to leave me alone

* chore: try again

* refactor: rephrase AC

* refactor: clarify

* refactor: fix spelling

* feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history (#1659)

* feat: update datanode spec with functionality to rollback node and functionality to fetch csv files containing network history

* fix: spell checker

---------

Co-authored-by: gordsport <[email protected]>
Co-authored-by: Gordsport <[email protected]>

* spec: draft for time-based mempool pruning (#1645)

* spec: draft for time-based mempool pruning

Signed-off-by: Elias Van Ootegem <[email protected]>

* spec: spelling

Signed-off-by: Elias Van Ootegem <[email protected]>

* Spelling + clarify how block height is determined

Signed-off-by: Elias Van Ootegem <[email protected]>

* spec: add some additional ACs, remove mention of TxV4, clarify that transaction data includes block hash in addition to block height

Signed-off-by: Elias Van Ootegem <[email protected]>

* complete acceptance criteria

Signed-off-by: Elias Van Ootegem <[email protected]>

* fix typo

Signed-off-by: Elias Van Ootegem <[email protected]>

---------

Signed-off-by: Elias Van Ootegem <[email protected]>
Co-authored-by: Gordsport <[email protected]>

* re-word ac

* chore: Add decision notes template (#1658)

* chore: Add decision notes template

Added a decision template based loosely on the [Any Decision Records](https://adr.github.io/madr/) template

Also updated some MD linting to allow sibling duplicated header titles and double spacing to make reading easier.

* fix: Spelling error

* feat: update for distributing remainder of liq fee

* fix: correct AC

* refactor: address feedback

* add spec for current collateral

* clarify total margin available

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7001-COLL-collateral.md

Co-authored-by: Michael <[email protected]>

* add asset file

* Add ACs for asset detail dialog and link up with collateral spec

* add suggested sort order per account type

* fix: 005 AC code link (#1671)

* fix: mempool pruning with PoW only

* fix: linting errors

* refactor: add liquidation price estimate

* refactor: add ACs

* refactor: another AC

* refactor: cosmetic change

* Update 0045-DSRC-data_sourcing.md (#1674)

* Update 0045-DSRC-data_sourcing.md

* Update 0045-DSRC-data_sourcing.md

* Wording of timestamp AC

---------

Co-authored-by: AnExsomnis <[email protected]>
Co-authored-by: Barney Mannerings <[email protected]>

* add spec for current functionality fo fills data grid

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* Make notional value of feels a could

* Update user-interface/7005-FILL-fills.md

Co-authored-by: Michael <[email protected]>

* add clarification on user role for trades during continuos vs auction

* fix: typo in ac number

* feat: update typo in 0061

* feat: add explaination on ersatz validators

* feat: correct typos

* feat: typo

* Update user-interface/7005-FILL-fills.md

* add browser wallet spec as part of approbation set up

* chore: fix typo and add browser specs to app.json

* chore: add browser wallet to categories, hopefully in the right place

* chore: Update 0033-OCAN-cancel_orders.md (#1686)

* feat: update BRIE specs (#1654)

* feat: update BRIE specs

Signed-off-by: Jeremy Letang <[email protected]>

* chore: update spelling and linting

* feat: update BRIE specs

Signed-off-by: Jeremy Letang <[email protected]>

* chore: update spelling and linting

* fix: spelling and lint and rebase

* fix: spelling

---------

Signed-off-by: Jeremy Letang <[email protected]>
Co-authored-by: gordsport <[email protected]>
Co-authored-by: Gordsport <[email protected]>

* chore: Update cosmic elevator branch from master (#1688)

* refactor: let max oi drop during auciton

* fix: duplicate AC codes in 0069-VCBS (#1536) (#1537)

* Update `cosmicelevator` branch from `master` branch (#1550)

* fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation

* fix: duplicate AC codes in 0069-VCBS (#1536)

* chore: trailing spaces

* fix: remove the unused netparam; not liking that

* chore: remove untestable AC from 0018 (#1530)

* chore: reword 0063-VALK-013

* Update 0035-LIQM-liquidity_monitoring.md (#1539)

* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md

* fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)

* Update 0011-NP-CLIE-client-interaction-tests.md

* feat: allow any key to request multisg signers update bundle

* feat: clarify spam status

* refactor: let max oi drop during auciton

* Wording tweaks for spam protection spec (#1548)

* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section

Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: Paul Webb <[email protected]>
Co-authored-by: RomanLeca <[email protected]>
Co-authored-by: Witold <[email protected]>
Co-authored-by: candida-d <[email protected]>

* Update cosmicelevator branch from master to keep up-to-date (#1560)

* fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation

* fix: duplicate AC codes in 0069-VCBS (#1536)

* chore: trailing spaces

* fix: remove the unused netparam; not liking that

* chore: remove untestable AC from 0018 (#1530)

* chore: reword 0063-VALK-013

* Update 0035-LIQM-liquidity_monitoring.md (#1539)

* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md

* fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)

* Update 0011-NP-CLIE-client-interaction-tests.md

* feat: allow any key to request multisg signers update bundle

* feat: clarify spam status

* refactor: let max oi drop during auciton

* Wording tweaks for spam protection spec (#1548)

* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section

* fix spelling in spam protection spec (#1553)

* Update 0069-VCBS-validators_chosen_by_stake.md

Added pending validator to VCBS-59

* Update 0069-VCBS-validators_chosen_by_stake.md

Clarification on 0059

* Update 0062-SPAM-spam_protection.md

* Update 0062-SPAM-spam_protection.md

fixed link to defaults.go

* Add quality checks to the makefile (#1556)

* fix: broken links in the specs (#1557)

* fix: remove broken kraken link

---------

Co-authored-by: David Siska <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: wwestgarth <[email protected]>
Co-authored-by: Paul Webb <[email protected]>
Co-authored-by: RomanLeca <[email protected]>
Co-authored-by: Witold <[email protected]>
Co-authored-by: candida-d <[email protected]>
Co-authored-by: Vegaklaus <[email protected]>

* chore: Update cosmicelevator from master branch (#1564)

* fix: bring market.liquidity.targetstake.triggering.ratio in line with implementation

* fix: duplicate AC codes in 0069-VCBS (#1536)

* chore: trailing spaces

* fix: remove the unused netparam; not liking that

* chore: remove untestable AC from 0018 (#1530)

* chore: reword 0063-VALK-013

* Update 0035-LIQM-liquidity_monitoring.md (#1539)

* Update 0035-LIQM-liquidity_monitoring.md

* Update 0035-LIQM-liquidity_monitoring.md

* fix AC numbering on 0035-LIQM-liquidity_monitoring.md (#1541)

* Update 0011-NP-CLIE-client-interaction-tests.md

* feat: allow any key to request multisg signers update bundle

* feat: clarify spam status

* refactor: let max oi drop during auciton

* Wording tweaks for spam protection spec (#1548)

* grammar etc fixes to spam protection
* fix linting errors
* chore: remove brackets
* docs: another round of rewording
* add related topics section

* fix spelling in spam protection spec (#1553)

* Update 0069-VCBS-validators_chosen_by_stake.md

Added pending validator to VCBS-59

* Update 0069-VCBS-valid…
  • Loading branch information
Show file tree
Hide file tree
Showing 64 changed files with 2,166 additions and 1,086 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/config/markdownlint.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
"MD024": {
"siblings_only": true
},
"MD049": false,
"MD049": false
}
7 changes: 0 additions & 7 deletions .github/workflows/quality_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,6 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Log in to the GitHub Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: "Run Check AC codes"
run: |
npx github:vegaprotocol/approbation check-codes --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md,./protocol/**/*.ipynb}"
Expand Down
2 changes: 1 addition & 1 deletion makefile
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ spellcheck:
# Checks for duplicated ACs in the features.json file
.PHONY: check-features
check-features:
npx github:vegaprotocol/approbation check-features --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md,./protocol/**/*.ipynb}" --features="./protocol/features.json"
npx github:vegaprotocol/approbation check-features --specs="{./non-protocol-specs/**/*.md,./protocol/**/*.md,./protocol/**/*.ipynb}" --features="./protocol/nebula-features.json"

clean:
rm -rf $(TEMP)
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ At the moment bots on Vega run on certain markets to make them look "real".
For that purpose they:

1. Are given large amounts of collateral via faucets.
1. Keep track of current futures price on another exchange (at e.g. 30s, 5 min intervals)
1. Keep track of current spot or futures price on another exchange (at e.g. 30s, 5 min intervals)
1. Post GTC limit orders randomly on both sides of the order book at random volumes using the above reference price as mid.

This achieves the following: the price on the market looks "real" and there is volume for participants to trade.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ This is primarily for liquidity providers and other sophisticated participants a
- An ETH address that is listed on the smart contract as exempt can deposit more than `max lifetime deposit`
- Any ETH address can use a method on the smart contract to add or remove itself (own ETH address) from the exemption list
1. `max lifetime deposit` can be updated per asset via an Ethereum transaction (<a name="0003-NP-LIMI-003" href="#0003-NP-LIMI-003">0003-NP-LIMI-003</a>)
1. Validators can, via multisig, stop and recommence processing bridge transactions (<a name="0003-NP-LIMI-004" href="#0003-NP-LIMI-004">0003-NP-LIMI-004</a>)
1. Validators can, via multisig, stop and recommence processing bridge transactions on any of the bridges (<a name="0003-NP-LIMI-007" href="#0003-NP-LIMI-007">0003-NP-LIMI-007</a>)
- A representative set of validators can produce a multisig transaction that stops all future deposits and withdrawals
- A representative set of validators can produce a multisig transaction that allows the bridge to resume processing future deposits and withdrawals
- All withdrawals that are submitted while the bridge is 'stopped' are rejected
Expand Down
3 changes: 2 additions & 1 deletion non-protocol-specs/0013-NP-POSE-position-estimate.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ The endpoint request contains additional optional argument `scale_liquidation_pr

1. In isolated margin mode the request with `0` open volume and one or more limit orders specified results in a non-zero order margin in the margin level estimate and margin mode correctly representing isolated margin mode. (<a name="0013-NP-POSE-001" href="#0013-NP-POSE-001">0013-NP-POSE-001</a>)
1. When account balances are set to `0` and market has slippage factors set to `0`, the collateral increase figure per specified theoretical position correctly approximates (absolute relative difference of less than $10^{-6}$) the actual margin and order margin account balances for a party which opens such a position. (<a name="0013-NP-POSE-002" href="#0013-NP-POSE-002">0013-NP-POSE-002</a>)
1. For a market with slippage cap factor set to `0`, when the response for a given request contains figure `x` as the collateral increase (best and worst case should be the same) then resubmitting the request with margin account balance increased by `x` should result in `0` collateral increase estimate. When increasing the margin account balance in the request further the collateral increase should get negative by the amount of the increase when in isolated margin mode. In cross margin mode it should remain at `0` until the combined margin and order balances are above the margin release level for the theoretical position. Then the collateral increase amount should be negative and equal to: `initial margin level for the specified position - margin account balance - order account balance`. (<a name="0013-NP-POSE-009" href="#0013-NP-POSE-009">0013-NP-POSE-009</a>)
1. In cross margin-mode, for a market with slippage cap factor set to `0`, the request to `EstimatePosition` endpoint is made with margin account balance set to less than the initial margin for the specified position, when the response for a given request contains figure `x` as the collateral increase (best and worst case should be the same) then resubmitting the request with margin account balance increased by `x` should result in `0` collateral increase estimate. When increasing the margin account balance in the request further it should remain at `0` until the combined margin and order balances are above the margin release level for the theoretical position. Then the collateral increase amount should be negative and equal to: `initial margin level for the specified position - margin account balance - order account balance`. (<a name="0013-NP-POSE-009" href="#0013-NP-POSE-009">0013-NP-POSE-009</a>)
1. In isolated margin mode: open a position so that open volume is non-zero and there are some open orders. Query the `EstimatePosition` with the details of that position. The collateral increase estimate should be 0. No query the `EstimatePosition` with a higher margin factor. The collateral increase estimate should be positive and equal to the decrease in the general account balance after margin factor is updated for the party. Now lower the margin factor below the value the test originally started with and repeat. The collateral increase estimate should be negative and equal to the decrease in the general account balance (the balance should increase). (<a name="0013-NP-POSE-010" href="#0013-NP-POSE-010">0013-NP-POSE-010</a>)
1. In isolated margin mode increasing general account balance specified in the request has no impact on the collateral increase estimate and the liquidation price estimate. (<a name="0013-NP-POSE-004" href="#0013-NP-POSE-004">0013-NP-POSE-004</a>)
1. In isolated margin mode the liquidation price estimate for a position with non-zero additional margin requirement with `include_collateral_increase_in_available_collateral` argument set to `true` results in liquidation price which is closer to the current mark price than the result obtained with argument set to `false`. (<a name="0013-NP-POSE-005" href="#0013-NP-POSE-005">0013-NP-POSE-005</a>)
1. When market is set with different number of decimal places then its settlement asset then setting `scale_liquidation_price_to_market_decimals` to `false` results in liquidation price estimates scaled to asset decimal places, when set to `true` these estimates get scaled to market decimal places. (<a name="0013-NP-POSE-006" href="#0013-NP-POSE-006">0013-NP-POSE-006</a>)
Expand Down
4 changes: 3 additions & 1 deletion protocol/0001-MKTF-market_framework.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Data:
- **Position Decimal Places**: number of decimal places for orders and positions, i.e. if this is 2 then the smallest increment that can be traded is 0.01, for example 0.01 BTC in a `BTSUSD` market.
- If this is negative e.g. -3 this means that the smallest order and position is of size 1000.
- Accepted values are `-6,...,-1,0,1,2,...,6`.
- **Tick size**: the minimum change in quote price for the market. Order prices and offsets for pegged orders must be given as an exact multiple of the tick size. For example if the tick size is 0.02 USD. then a price of 100.02 USD is acceptable and a price of 100.03 USD is not. The tick size of a market can be updated through governance. Note, the tick size should be specified in terms of the market decimals, e.g. for a scaled tick size of `0.02` (USDT) in a market using `5` decimal places, the tick size would be set to `2000`.
- **Liquidation strategy**: A field specifying the liquidation strategy for the market. Please refer to [0012-POSR-position_resolution](./0012-POSR-position_resolution.md#managing-networks-position) for supported strategies.

Note: it is agreed that initially the integer representation of the full precision of both order and positions can be required to fit into an int64, so this means that the largest position/order size possible reduces by a factor of ten for every extra decimal place used. This also means that, for instance, it would not be possible to create a `BTCUSD` market that allows order/position sizes equivalent to 1 sat.
Expand Down Expand Up @@ -80,6 +81,7 @@ Data:
- **Name:** full and fairly descriptive name for the instrument.
- **Metadata fields:** A series of arbitrary strings that can be used in clients
- **Product:** a reference to or instance of a fully specified product, including all required product parameters for that product.
- **Community Tags:** A list of string community tags assigning the market to certain categories. Each of these is a free text field of a network parameter defined maximum length. These are managed through a separate proposal type and cannot be set at market creation or changed in a normal market update proposal.

## Product

Expand Down Expand Up @@ -221,7 +223,7 @@ Market {
## Successor market

If a market proposal, see [governance](./0028-GOVE-governance.md), designates an existing market as a *parent market* then it must have the same *product*, *settlement asset(s)* and *margin asset(s)*.
It may propose new risk model and parameters, price monitoring parameters, position and market decimal places.
It may propose new risk model and parameters, price monitoring parameters, tick size, position and market decimal places.
It must provide oracle definitions, both for trading terminated and for settlement data.
Each market can have exactly one market as a *successor* market.

Expand Down
1 change: 1 addition & 0 deletions protocol/0002-STTL-settlement.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,4 @@ All of that happens while processing the trading terminated transaction.
1. The [market's insurance pool](./0015-INSR-market_insurance_pool_collateral.md) balance is transferred into the global insurance pool using the same settlement asset.
1. Market status is now set to [SETTLED](./0043-MKTL-market_lifecycle.md).
1. Now the market can be deleted.

Loading

0 comments on commit 012ebdd

Please sign in to comment.