Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to the playwright examples #1515

Open
3 tasks
victhorbi opened this issue Nov 14, 2024 · 2 comments
Open
3 tasks

Add support to the playwright examples #1515

victhorbi opened this issue Nov 14, 2024 · 2 comments

Comments

@victhorbi
Copy link
Collaborator

victhorbi commented Nov 14, 2024

Context
The major source of incompatibilities so far was with the browser runtime environment, to tackle before time next issues with local setups, can be good to increase coverage in the most elegant, automated way.
The Team proposed to consider Playwrite in our toolchain.

From the introduction it says " Playwright supports all modern rendering engines including Chromium, WebKit, and Firefox. Test on Windows, Linux, and macOS, locally or on CI, headless or headed with native mobile emulation of Google Chrome for Android and Mobile Safari."

Description

  • Do integrate Playwrite.
  • Write a confluence page to help changing configuration.
  • Add a Github Action to have the tests going E2E in the CI/CD

The expected outcome is that it should take care of the basic compatibility with most of the execution environment.

@victhorbi victhorbi changed the title Add support to the playright examples Add support to the playwright examples Nov 15, 2024
@leszek-vechain leszek-vechain self-assigned this Nov 27, 2024
@leszek-vechain
Copy link
Collaborator

I have had a quick review of our example apps and here are the results:

  • vite - uses hashing in real time, tx logs and get the last block (via button click). It has UI and uses mainnet.
  • node - console app, which shows results on console. No UI uses testnet.
  • next js - uses hashing in real time, tx logs but no get the last block button. It has UI and uses mainnet.
  • hardhat - just deploying/interacting with contracts. No UI. uses solo and testnet.
  • cloudflare - jsut simple example on web page (pure text)

So potential candidates for Playwright are vite and nextjs example. Another question is if we want to make existing examples consistent ? (except probably hardhat) As right now we use different chains and show some different stuff.

@victhorbi
Copy link
Collaborator Author

The Team agrees that most of the value comes from vite and next js UI capabilities, while the network of bigger interest is mainnet, since the SDK should always be aligned with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants