Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token endpoint authentication method supports only Basic Auth #69

Open
jakub-pietrzak opened this issue May 24, 2023 · 0 comments
Open

Comments

@jakub-pietrzak
Copy link

jakub-pietrzak commented May 24, 2023

The OidcClient currently only supports authentication with the token endpoint using Basic Auth.

https://github.com/vaulttec/sonar-auth-oidc/blob/v2.1.1/src/main/java/org/vaulttec/sonarqube/auth/oidc/OidcClient.java#L168

TokenRequest request = new TokenRequest(tokenEndpointURI, new ClientSecretBasic(getClientId(), getClientSecret()),
          new AuthorizationCodeGrant(authorizationCode, new URI(callbackUrl)));

It is sometimes necessary (due to security/other factors) to use different methods like client secret POST, which makes it more difficult to use the plugin when the Basic Auth is not supported for the token endpoint.

Would be great if the authentication method was configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants