Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

[Feature Request] Collect column names in create task #138

Closed
3 tasks done
bartvanb opened this issue Oct 26, 2023 · 2 comments
Closed
3 tasks done

[Feature Request] Collect column names in create task #138

bartvanb opened this issue Oct 26, 2023 · 2 comments
Assignees

Comments

@bartvanb
Copy link
Member

bartvanb commented Oct 26, 2023

Problem description
In creating tasks, there are steps to do data preprocessing (extending and filtering it). These steps require the column names of the data to be known at that point, e.g. because if you want to compute the age given a date of birth column, you need to know what the name of that column is.

Desired solution

  • When a user initiates a first preprocessing step, collect the column names with the /column endpoint.
  • Alert the user that this is taking place and that they may wait a short while
  • Handle case where the endpoint fails - error message

Additional context
Link to the backend implementation issue: vantage6/vantage6#778

@bartvanb
Copy link
Member Author

bartvanb commented Nov 9, 2023

This is already partly implemented. However, we didn't cover all features yet:

  • If there is a function argument of type 'column', the columns still have to be collected when reaching the final step in task-create to set argument values and displayed as dropdown for the relevant arguments
  • If new columns are created in the preprocessing section, they should be added to the column list

@bartvanb bartvanb self-assigned this Nov 9, 2023
@bartvanb bartvanb added this to Sprints Dec 6, 2023
@github-project-automation github-project-automation bot moved this to Todo in Sprints Dec 6, 2023
@bartvanb
Copy link
Member Author

Closing this as it has already been implemented by now

@github-project-automation github-project-automation bot moved this from Todo to Done in Sprints Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

1 participant