Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice viewer, and some issues I found #66

Open
yanzexuan1 opened this issue May 31, 2023 · 1 comment
Open

Nice viewer, and some issues I found #66

yanzexuan1 opened this issue May 31, 2023 · 1 comment

Comments

@yanzexuan1
Copy link

Hello Vagran,

Nice to see your dxf-viewer, wonderful tool! We also created our own dxf viewer, but not open sourced! I tried your example web site, it already supports plenty of dxf features with a pretty good performance. Great job.

One file has some issue, as you can see, the color, and some hatches are not rendererd correctly. You may take a look when there is chance.
image

The file is here:
https://github.com/pattern-x/gemini-viewer-examples/blob/main/public/demo/models/dxf/rac_basic_sample_project.dxf

It looks like this in our system:
https://pattern-x.github.io/gemini-viewer-examples/#/Rac_basic_sample_project_dwg
image

@vagran
Copy link
Owner

vagran commented May 31, 2023

Hello,
Thanks for the report! Yes, solid hatch type is currently not implemented feature. A good sample file is the first step towards the implementation, so thanks for the example file.
For non-solid pattern, at first look, it seems like a bug in handling custom patterns. And it is also the first example with such patterns defined in HATCH entity, so now I have a chance to fix and test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants