Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Taiwan's unofficial holidays #1912

Open
Curtis081 opened this issue Aug 9, 2024 · 2 comments
Open

Implement Taiwan's unofficial holidays #1912

Curtis081 opened this issue Aug 9, 2024 · 2 comments

Comments

@Curtis081
Copy link

Curtis081 commented Aug 9, 2024

Bug Report

Expected & Actual Behavior

Labor Day is a holiday. but the information not in the module(holidays) - Taiwan class

Environment

  • OS: Windows 10
  • Python version: 3.11
  • holidays version: 0.54

Additional Context

The following is my use example, it will raise the Error. Cause the variable this_is_holiday not in tw_holidays.

import holidays
from datetime import datetime

Taiwan_labor_day = datetime(2024, 5, 1)
Double_tenth_Day = datetime(2024, 10, 10)
  
the_day = Taiwan_labor_day
  
tw_holidays = holidays.Taiwan()
this_is_holiday = the_day in tw_holidays
assert this_is_holiday
@arkid15r arkid15r changed the title Taiwan's labor day is 5/1 every year, it is holiday. Implement Taiwan's unofficial holidays Aug 9, 2024
@arkid15r
Copy link
Collaborator

arkid15r commented Aug 9, 2024

Thanks for reporting this @Curtis081
It seems there is a list of unofficial holidays that hasn't been covered yet.

I've updated the issue title based on that info.

@Curtis081
Copy link
Author

Curtis081 commented Aug 10, 2024

Thank you for your attention and assistance! I have resolved the issue in my project by adding conditional statements.

By the way, there was a small problem with Python inspections: it showed the message "Cannot find reference 'Taiwan' in 'init.py.'"

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants