You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current version has 2 main types of supported entities: country and financial. Not all entities of the country type can be countries per se. As ISO3166 defines a broader set of supported entities, e.g. names of countries, dependent territories, and special areas of geographical interest it'd be fair to rename accordingly, use iso3166 as a placeholder for iso3166 based entities. Keeping it as is for financial/market category can be a good idea.
The iso3166 entity files would be named according to their iso3166-1 codes.
Another point is the difference for specifying the code for country/market entities: using a standardized attribute name for both types would be more consistent. The difference could be provided based on class inheritance (separate base classes for iso3166 and financial entities) and/or entity_type field.
Questions and ideas are welcome!
The text was updated successfully, but these errors were encountered:
The current version has 2 main types of supported entities: country and financial. Not all entities of the country type can be countries per se. As ISO3166 defines a broader set of supported entities, e.g.
names of countries, dependent territories, and special areas of geographical interest
it'd be fair to rename accordingly, useiso3166
as a placeholder for iso3166 based entities. Keeping it as is for financial/market category can be a good idea.The iso3166 entity files would be named according to their iso3166-1 codes.
Another point is the difference for specifying the code for country/market entities: using a standardized attribute name for both types would be more consistent. The difference could be provided based on class inheritance (separate base classes for iso3166 and financial entities) and/or
entity_type
field.Questions and ideas are welcome!
The text was updated successfully, but these errors were encountered: