Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip long running tests with env var instead of hard-coded variable #43

Open
Aariq opened this issue Nov 13, 2024 · 1 comment
Open

Comments

@Aariq
Copy link
Collaborator

Aariq commented Nov 13, 2024

Currently whether long tests are skipped or not is handled by a get_skip_long_tests() in zzz.R that is hard-coded to return TRUE. Might be better to control this with an environment variable, e.g., NPN_RUN_LONG_TESTS and have skip_long_tests() return !Sys.getenv("NPN_RUN_LONG_TESTS")

@Aariq
Copy link
Collaborator Author

Aariq commented Nov 14, 2024

Should also explore the possibility that these tests don't need to be downloading so much data. The point is to test the R functions, not the API or the data—maybe tests can be pared down to download a much smaller slice of data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant