Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rxjs behaviorSubject isn't needed in notification service #58

Open
abrahamq opened this issue Sep 7, 2018 · 0 comments
Open

Rxjs behaviorSubject isn't needed in notification service #58

abrahamq opened this issue Sep 7, 2018 · 0 comments
Assignees
@ojha-url

Comments

@abrahamq
Copy link
Member

abrahamq commented Sep 7, 2018

It looks like we import BehaviorSubject only to turn it into an observable with .asObservable later. Why not just make an observable? Would shave off some weight from our bundle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ojha-url ojha-url

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abrahamq @ojha-url