Source code housekeeping #12576
adeelhasan
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
https://docs.soliditylang.org/en/v0.8.17/style-guide.html
Does it make sense to update your files as per those recommendations? Some of the files were first put in place when there were no guides probably, so this is more of a catch up to the times sort of suggestion.
When building the project, or running tests, there is overhead in going through previous versions eg. migration tests run, and older versions are also compiled. When I do search in files, it will look through that code too. Ideally, older versions get a sunset, and they go into an archival repo. But there is perhaps a reason why the older versions are still worth keeping around in the same repo?
along the same lines, does it make sense to split up the current repo into separate ones for front end, contract, subgraph etc?
Beta Was this translation helpful? Give feedback.
All reactions