Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createHmac (from node:crypto) is not implemented for nodeless targets #291

Open
zou-yu opened this issue Aug 1, 2024 · 5 comments
Open
Labels

Comments

@zou-yu
Copy link

zou-yu commented Aug 1, 2024

Environment

nodejs20
"nuxt": "^3.12.3",
wrangler:

compatibility_date = "2024-07-01"
compatibility_flags = ["nodejs_compat"]

Reproduction

Just enable nodejs-compat in wrangler and using cloudlfare_module preset, you will get the same error:
[unenv] crypto.createHmac is not implemented yet!

Describe the bug

Cannot use createHmac in cloudflare worker with cloudflare_module preset,
got error: [unenv] crypto.createHmac is not implemented yet!
but createHmac is supported in cloudflare worker: https://developers.cloudflare.com/workers/runtime-apis/nodejs/crypto/

Additional context

No response

Logs

[unenv] crypto.createHmac is not implemented yet!
@zou-yu zou-yu added the bug Something isn't working label Aug 1, 2024
@pi0 pi0 added crypto and removed bug Something isn't working labels Aug 2, 2024
@pi0 pi0 changed the title Cannot use createHmac in cloudflare worker with cloudflare_module preset createHmac (from node:crypto) is not implemented for nodeless targets Aug 2, 2024
@Flowko
Copy link

Flowko commented Aug 26, 2024

would love to see this implemented, the only thing stopping me from using it with lucia auth.

@vicb
Copy link
Contributor

vicb commented Oct 11, 2024

@zou-yu @Flowko this is now implemented (natively) in cloudflare.

@pi0 not sure if you want to close this issue or leaving it open for nodeless

@pi0
Copy link
Member

pi0 commented Oct 11, 2024

@vicb

  1. unenv support is not limited to cloudflare
  2. even for cloudflare we cannot upgrade to unenv v2 for Nitr/Nuxt because of the blockers I shared with you

This issue is not solved at least for original reported problem.

@vicb
Copy link
Contributor

vicb commented Oct 12, 2024

Thanks for the clarification @pi0!

  1. unenv support is not limited to cloudflare

Yep, that's why I asked about closing this PR.

  1. even for cloudflare we cannot upgrade to unenv v2 for Nitr/Nuxt because of the blockers I shared with you

I thought the reported issue was solved. I didn't consider v1 vs v2.

@radum2o18
Copy link

any updates on this issue? would also love to see this implemented. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants