Merge pull request #39 from unicef-polymer/linting-task

Linting tasks

.eslintrc.json

@@ -10,21 +10,21 @@
     "html"
   ],
   "rules": {
+    "padded-blocks": "off",
     "brace-style": "off",
-    "new-cap": ["error", { "capIsNewExceptions": ["Polymer"] }],
+    "new-cap": ["error", { "capIsNewExceptions": ["Polymer"], "capIsNewExceptionPattern": "^Etools.." }],
     "no-var": "off",
-    "operator-linebreak": 1,
-    "no-trailing-spaces": 1,
-    "valid-jsdoc": 0,
-    "camelcase": 1,
-    "guard-for-in": 0,
-    "comma-dangle": 0,
-    "prefer-spread": 0,
-    "linebreak-style": 0,
     "require-jsdoc": "off",
-    "max-len": ["error", 120, 4]
+    "valid-jsdoc": "off",
+    "comma-dangle": ["error", "never"],
+    "max-len": ["error", { "code": 120 }],
+    "camelcase": ["error", {"properties": "never"}],
+    "arrow-parens": [2, "as-needed", { "requireForBlockBody": true }]
   },
   "globals": {
-    "Polymer": true
+    "moment": true,
+    "Promise": true,
+    "Polymer": true,
+    "EtoolsLogsMixin": true
   }
 }

README.md

@@ -138,22 +138,6 @@ $ bower install --save etools-ajax
 Install needed dependencies by running: `$ bower install`.
 Make sure you have the [Polymer CLI](https://www.npmjs.com/package/polymer-cli) installed. Then run `$ polymer serve` to serve your element application locally.
 
-## Linting the code
-
-Innstall local npm packages (run `npm install`)
-Then just run the linting task
-
-```bash
-$ npm run lint
-```
-You should also use polylint. If you don't have Polylint installed run `npm install -g polylint`.
-Then just run the linter on each file you wish to check like so
-
-```bash
-$ polylint -i filename.html
-```
-At the moment polylint crashes if it encounters a missing import. If that happens, temporarily comment out such imports and run the command again.
-
 ## Running Tests
 
 You need to have `web-component-tester` installed (if not run `npm install -g web-component-tester`)

etools-ajax-cache-mixin.html

@@ -27,6 +27,7 @@
     }
 
     ready() {
+      super.ready();
       if(typeof Dexie === 'undefined') {
         this.logError('Dexie import missing.', 'etools-ajax');
       }

package.json

@@ -6,7 +6,6 @@
     "eslint-plugin-html": "^2.0.0"
   },
   "scripts": {
-    "lint": "npm run lint:javascript && exit 0",
     "lint:javascript": "eslint . --ext js,html && exit 0"
   }
 }

polymer.json

@@ -0,0 +1,11 @@
+{
+  "lint": {
+    "rules": [
+      "polymer-2"
+    ],
+    "filesToIgnore": [
+      "demo/*",
+      "test/*"
+    ]
+  }
+}