Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differentiate between sparse and non sparse basisfunctions #11

Open
behinger opened this issue Mar 31, 2020 · 1 comment
Open

differentiate between sparse and non sparse basisfunctions #11

behinger opened this issue Mar 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@behinger
Copy link
Member

behinger commented Mar 31, 2020

E.g. BOLD-basis is non-sparse, and the designmatrix will generally be non-sparse as well
but FIR-basis is sparse.

a new field in the basisfunction type could be specified. This field would then decide whether the designmatrix Xdc is sparse and whether it needs to be fitted by iterative solvers or not.

====
Another problem: basisfunction.times is illdefined for some bases (e.g. BOLD).
maybe should be replaced by basisfunction.colnames. But e.g. for FIR we need to know at a later point, how many negative samples there are, to move the onset of the basis to the correct sample.

@behinger
Copy link
Member Author

second problem is solved. But not yet through all instances of basisfunction.times, e.g. tutorials are still missing

@behinger behinger added the enhancement New feature or request label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant