Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettier-plugin-sql: Update to sql-formatter@14? #313

Closed
karlhorky opened this issue Nov 26, 2023 · 2 comments · Fixed by #315
Closed

prettier-plugin-sql: Update to sql-formatter@14? #313

karlhorky opened this issue Nov 26, 2023 · 2 comments · Fixed by #315

Comments

@karlhorky
Copy link
Contributor

Hi @JounQin, hope you're well! 👋

I saw that there was a new version [email protected], which introduces a new identifierCase option

2 breaking changes, apparently removal of options which were already deprecated and broken:

Breaking changes

These already deprecated features were fundamentally broken and have been removed for good:

  • Removed tabulateAlias config option.
  • Removed commaPosition config option.

What do you think about upgrading to this new major version?
@JounQin
Copy link
Member

JounQin commented Nov 26, 2023 •
edited
Loading

PR welcome, I think that would be very smooth by just upgrading dependencies adding a new option.

@karlhorky karlhorky mentioned this issue Nov 27, 2023
Merged
@karlhorky
Copy link
Contributor Author

Ok, PR open at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: upgrade to sql-formatter v14, remove tabulateAlias and commaPosition options
2 participants
@karlhorky @JounQin