Allow repeat REQBUF when buffers not mapped #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow repeated VIDIOC_REQBUF when no buffers are mapped (fix #598) by:
ready_for_output
back to 1 invidioc_streamoff
.vidioc_reqbufs
when ready-for-output is true.I hope I haven't messed up the logic for
dev->ready_for_output
. The comments suggest:More precisely, it looked to me like it was initialised as true and set to false (only) once
vidioc_streamon
is called - i.e. when the output process is started in streaming (memory mapping) I/O. Thus it should be safe to return it to true oncevidioc_streamoff
is called.I contemplated whether I also needed to add a check that the opener is assigned WRITER type in stream-off, but have left it out for now, e.g.: