Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15 - Bellissima - settingsValues not observed in block-entry-context.ts #17607

Closed
InfiniteSpirals opened this issue Nov 21, 2024 · 2 comments
Closed
Labels

Comments

@InfiniteSpirals
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0

Bug summary

When implementing a custom block list view controller (from the example implementation in Umbraco.Web.Ui.Client/examples/block-custom-view.ts) in a clean U15 install, with a block list editor setup with a block with a content model and settings model, the settings model is not observed and the properties are never passed through to the settings property in the ExampleBlockCustomView.

Debugging source .ts for block-entry-context.ts in chrome tools shows that at in the method
public async settingsValues() on line 226 of Umbraco.Web.Ui.Client/packages/block/block/block-entry-context.ts - seems to never execute past the call to await this.#settingsStructurePromise; on line 227.

Specifics

No response

Steps to reproduce

Install a clean U15 install and implement the example "ExampleBlockCustomView" component from Umbraco.Web.Ui.Client/examples/block-custom-view.ts.

Any changes made to settings are not observed, only content. Settings is always undefined within the ExampleBlockCustomView despite being set in the settings model.

Expected result / actual result

Settings should be observed and trigger updates when changed. this.settings should be populated on the ExampleBlockCustomView

Copy link

Hi there @InfiniteSpirals!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nielslyngsoe
Copy link
Member

@InfiniteSpirals thanks for reporting this. As a user of the Block Editor you should look forward to 15.1, which in general corrects and fixes various things in these Property Editors.
This specific issue is also fixed in this version by this PR.
#17578

Therefor I'm closing this issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants