Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cougar Dave browse blur on long PDFs #15

Open
aweymo-ui opened this issue Jul 5, 2024 · 5 comments
Open

Cougar Dave browse blur on long PDFs #15

aweymo-ui opened this issue Jul 5, 2024 · 5 comments
Assignees

Comments

@aweymo-ui
Copy link

Running into image quality problems on the browse page of Cougar Dave for long PDF images. I replaced all smalls and thumbs with the updated rake task but there are still some blurry images on the browse page.

@evanwill
Copy link
Member

evanwill commented Jul 6, 2024

@aweymo-ui the images look correct size. It maybe images cached in your browser? Did you test in a fresh private window on firefox?

@aweymo-ui
Copy link
Author

Yep! Must have been a cache issue. I'll mark this as resolved.

@evanwill
Copy link
Member

evanwill commented Jul 8, 2024

@aweymo-ui my only remaining question is if the really tall newspaper clipping images are disruptive to the flow of the Browse?
I think there is just a couple of them, in which case: a) may not be worth doing anything, just leave them or b) could go manually edit the thumbnail images and crop them down to a reasonable size.

@aweymo-ui
Copy link
Author

Creating unique derivatives feels like it might cause issues in the future. It seems like a good programmatic solution would be to add something to the browse layout that says, if a card is taller than x amount of pixels, automatically resize to x amount of pixels.

@evanwill
Copy link
Member

evanwill commented Jul 9, 2024

you could limit the size displayed on Browse with CSS, but not a great solution because the user still has to load the full size image (which are bigger than normal), and then doesn't get to see it.
Might add something to the Rake task in general, limiting the full height. But honestly, creating unique derivatives isn't a big deal--thats part of the flexibility of cb-csv, that you can pragmatically create custom stuff if it makes sense, rather than trying to account for every thing in your template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants