Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: font family extesion demo #5880

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix: font family extesion demo #5880

merged 1 commit into from
Nov 27, 2024

Conversation

alexvcasillas
Copy link
Contributor

Changes Overview

This PR aims to fix the Font Family extension demo

Implementation Approach

Correctly make use of the returned value from the textStyle API

Testing Done

Demo is correctly working

Verification Steps

Additional Notes

Will update the docs with additional information for the users about the returned value from textStyle API so they don't get confused it this happens to them while setting the plugin

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

@alexvcasillas alexvcasillas added the Type: Documentation The issue or pullrequest is related to documentation label Nov 27, 2024
@alexvcasillas alexvcasillas self-assigned this Nov 27, 2024
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: 80fd925

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 80fd925
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/674743401ec19800083d9b47
😎 Deploy Preview https://deploy-preview-5880--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -79,13 +79,6 @@ export default () => {
>
CSS variable
</button>
<button
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this button since I don't see any utility into it and does not apply for any of the cases that we're showcasing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 yep

Copy link

pkg-pr-new bot commented Nov 27, 2024

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@5880

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@5880

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@5880

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@5880

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@5880

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@5880

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@5880

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@5880

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@5880

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@5880

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@5880

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@5880

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@5880

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@5880

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@5880

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@5880

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@5880

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@5880

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@5880

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@5880

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@5880

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@5880

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@5880

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@5880

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@5880

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@5880

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@5880

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@5880

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@5880

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@5880

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@5880

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@5880

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@5880

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@5880

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@5880

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@5880

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@5880

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@5880

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@5880

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@5880

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@5880

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@5880

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@5880

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@5880

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@5880

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@5880

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@5880

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@5880

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@5880

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@5880

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@5880

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@5880

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@5880

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@5880

commit: 80fd925

@nperez0111 nperez0111 merged commit a8c8db6 into develop Nov 27, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation The issue or pullrequest is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants