Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 612: Change Disk parent class to StorageMedium #621

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Issue 612: Change Disk parent class to StorageMedium #621

merged 7 commits into from
Oct 22, 2024

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Jul 26, 2024 •
edited
Loading

This Pull Request resolves all backwards-incompatible requirements of Issue #612 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop-2.0.0
  • CI passes in UCO current unstable-2.0.0 branch (dd607e1)
  • CI passes in CASE current unstable-2.0.0 branch tracking UCO's unstable-2.0.0 as submodule (0fd2858)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora (N/A)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Warn if a Disk instance is not also a Device
03a3d3c 
Test cases omitted from ontology's tests because CASE example data are
known to use `uco-observable:Disk`.

No effects were observed on Make-managed files.

References:
* #612

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Merge branch 'develop-2.0.0' into Feature-Issue-612-2.0.0
91d3313
@ajnelson-nist
Change Disk parent class to Device
85335bc 
No effects were observed on Make-managed files.

References:
* #612

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone Jul 26, 2024
@ajnelson-nist ajnelson-nist linked an issue Jul 26, 2024 that may be closed by this pull request
Should Disk be a subclass of Device? #612
Closed
13 tasks
@ajnelson-nist ajnelson-nist changed the title Issue 612: Change Disk parent class to Device Issue 612: Change Disk parent class to StorageMedium Jul 29, 2024
@ajnelson-nist
Warn if a Disk instance is not also a StorageMedium
a271750 
No effects were observed on Make-managed files.

References:
* #612

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Merge branch 'Feature-Issue-612' into Feature-Issue-612-2.0.0
8be6351
@ajnelson-nist
Change Disk parent class to StorageMedium
482a726 
No effects were observed on Make-managed files.

References:
* #612

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Copy link
Contributor Author

I will clean up the dictionary effects.

@ajnelson-nist
Copy link
Contributor Author

I will clean up the dictionary effects.

The dictionary effects turned out to be from this PR not being caught up with a recent merge of develop-2.0.0. Caught up, the PR is now reduced to the expected 1-liner.

@ajnelson-nist ajnelson-nist mentioned this pull request Aug 28, 2024
Closed
13 tasks
@ajnelson-nist
Copy link
Contributor Author

This PR is ready for review and merge.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review October 21, 2024 14:19
@plbt5 plbt5 merged commit eb1592f into develop-2.0.0 Oct 22, 2024
1 check passed
@plbt5 plbt5 deleted the Feature-Issue-612-2.0.0 branch October 22, 2024 07:53
@ajnelson-nist ajnelson-nist mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging this pull request may close these issues.

Should Disk be a subclass of Device?
2 participants
@ajnelson-nist @plbt5