Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing deprecated np.object for numpy >= 1.24 #49

Conversation

fgoudreault
Copy link

@fgoudreault fgoudreault commented Dec 21, 2022

np.object is deprecated since numpy 1.20 but since 1.24, the deprecation is enforced (see numpy release notes).
More details: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
Fixes #50

@fgoudreault fgoudreault changed the title Fixing deprecated np.object for numpy >= 1.20 Fixing deprecated np.object for numpy >= 1.24 Dec 21, 2022
@tsinggggg
Copy link

numpy 1.24 has another deprecation that will break tests.
https://github.com/uchicago-cs/deepdish/blob/master/deepdish/util/padding.py#L95
will not be supported

@fgoudreault
Copy link
Author

numpy 1.24 has another deprecation that will break tests. https://github.com/uchicago-cs/deepdish/blob/master/deepdish/util/padding.py#L95 will not be supported

Hi @tsinggggg ! Thanks for the notice but I believe this repo is dead (last commit in 2021). Therefore I don't think I'll put more efforts into this and close the MR

@mepster
Copy link

mepster commented Sep 27, 2023

@tsinggggg do you have a fix for that?

@ami-navon
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy >= 1.24 enforces deprecation of np.object
4 participants