Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add the same hooks to all hierarchical modules #564

Open
colinschmidt opened this issue Feb 21, 2020 · 2 comments
Open

Ability to add the same hooks to all hierarchical modules #564

colinschmidt opened this issue Feb 21, 2020 · 2 comments
Labels
advanced PR bug enhancement medium priority Hard workaround exists, costing time/effort, chip QoL/QoR issue

Comments

@colinschmidt
Copy link
Contributor

If my project needs to add hooks and is using a hierarchical flow I need to create a dictionary for all possible modules names.

def get_extra_hierarchical_par_hooks(self, driver: HammerDriver) -> Dict[str, List[HammerToolHookAction]]:

While the current scheme is powerful it doesn't allow me to specify hooks that should be added to all modules.
Ideally a hybrid scheme would be best, perhaps using a dictionary entry like * to note which hooks should be applied to all modules.

@harrisonliew
Copy link
Contributor

harrisonliew commented Feb 28, 2020

@colinschmidt - you could use get_extra_par_hooks for this.

However, doing this would also introduce a bug. If I have a level of hierarchy that needs to be not bound to the common par hooks, I can't override anymore.

@colinschmidt
Copy link
Contributor Author

Yeah @harrisonliew, the bug you note is why I think we need some solution for this case of overridable defaults for hierarchical hooks.

@harrisonliew harrisonliew added bug CurrentTapeout This issue is needed for an ongoing tapeout at UCB enhancement medium priority Hard workaround exists, costing time/effort, chip QoL/QoR issue labels Feb 28, 2020
@colinschmidt colinschmidt added advanced PR and removed CurrentTapeout This issue is needed for an ongoing tapeout at UCB labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced PR bug enhancement medium priority Hard workaround exists, costing time/effort, chip QoL/QoR issue
Projects
None yet
Development

No branches or pull requests

2 participants