Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to deliver a message should fail gracefully #586

Open
chuck-sys opened this issue Oct 31, 2020 · 0 comments
Open

Failing to deliver a message should fail gracefully #586

chuck-sys opened this issue Oct 31, 2020 · 0 comments
Labels
priority:high For issues with high priority, because of deadlines, security reasons, or sometimes both. theme:bug Something isn't working theme:docs Create or update documentation theme:tooling Add or change our tooling, builds, or deployment theme:ux User experience improvements

Comments

@chuck-sys
Copy link
Collaborator

Summary

Failing to deliver a message should fail gracefully, with a proper error message and handler, instead of without one, which caused a production deployment issue.

Reproduction steps

  1. Follow dev guide
  2. Change default channels to newly created channels that Rocket has yet seen (or been invited to)
  3. Start Rocket

Expected behaviour

Logs that clearly say what is wrong (in this case, that we couldn't send the Rocket has restarted successfully :clap: :clap:). In this case to correct it, we just install the app into the channel.

Context

We also will want to update the documentation to reflect this. Add that the developer will have to install the app into all the specified channels in order to see anything.

@chuck-sys chuck-sys added theme:bug Something isn't working theme:tooling Add or change our tooling, builds, or deployment theme:docs Create or update documentation priority:high For issues with high priority, because of deadlines, security reasons, or sometimes both. theme:ux User experience improvements labels Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high For issues with high priority, because of deadlines, security reasons, or sometimes both. theme:bug Something isn't working theme:docs Create or update documentation theme:tooling Add or change our tooling, builds, or deployment theme:ux User experience improvements
Projects
None yet
Development

No branches or pull requests

1 participant