Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

team: grant team lead maintainer permissions on github team #547

Open
DConnorFong opened this issue Oct 7, 2020 · 2 comments · Fixed by #595
Open

team: grant team lead maintainer permissions on github team #547

DConnorFong opened this issue Oct 7, 2020 · 2 comments · Fixed by #595
Assignees
Labels
good first issue Good for newcomers theme:feature Request a new feature.

Comments

@DConnorFong
Copy link

Summary

Could be a bug but I am not too sure what the intended behavior is

Requirements

Steps:

  1. /rocket team create $TEAM --lead $YOU --channel $CHANNEL
  2. Under $YOU I tag myself in Slack
  3. Generate the team

Expected:
I would be a maintainer of the newly generated team

Actual:
I am not

Context

This seems like a good step to automate as it contributes to a pain point of organization owners having to manually set this up for me.

@DConnorFong DConnorFong added the theme:feature Request a new feature. label Oct 7, 2020
@bobheadxi
Copy link
Member

@chuck-sys
Copy link
Collaborator

chuck-sys commented Oct 7, 2020

We may want to either change the GithubInterface to include a add_team_maintainer() function, or we can append another parameter to GithubInterface.add_team_member(). Both seem fine.

For the person who implements this in the near future: https://pygithub.readthedocs.io/en/latest/github_objects/Team.html?highlight=add_membership#github.Team.Team.add_membership

https://developer.github.com/v3/teams/members/#parameters

@chuck-sys chuck-sys added the good first issue Good for newcomers label Oct 7, 2020
@bobheadxi bobheadxi changed the title Rocket Team Create Initializing $YOU as Team Maintainer team: grant team lead maintainer permissions on github team Oct 14, 2020
@no-or no-or self-assigned this Nov 8, 2020
@chuck-sys chuck-sys reopened this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers theme:feature Request a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants