Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce reliance on 'team refresh' #490

Open
1 of 2 tasks
bobheadxi opened this issue Sep 25, 2020 · 1 comment
Open
1 of 2 tasks

reduce reliance on 'team refresh' #490

bobheadxi opened this issue Sep 25, 2020 · 1 comment
Labels
theme:refactoring Something needs to be cleaned up or refactored

Comments

@bobheadxi
Copy link
Member

bobheadxi commented Sep 25, 2020

I implemented #484 as a part of team refresh, but @cheukyin699 brought up some good points against it:

Okay so here's the thing. /rocket team refresh takes around 20 seconds to execute (last I checked). The more members we have in Launch Pad, the longer it takes, O(n). We'll still need ways for users to receive the permission sharing automatically, whether if it is a user just adding their emails, or a team adding a folder ID into the system.

I am very adamant about not using /rocket team refresh unless we really need to because ... there are lots of side effects that I don't know about, that may be disruptive. For example, today I found out that it would forcefully add a user back into the organization if the user was in ddb but was already out of the org (one possibility would be if the user ID was still in a team in ddb).

I wasn't aware of the difficulties here because I didn't delve very deeply, but this can certainly get quite concerning, and at the moment I'm not actually 100% sure #484 will work very well once rolled out to our ~200 person Rocket deployment. Will keep an eye on this, but I'm guessing this task will encapsulate:

@bobheadxi bobheadxi added the theme:refactoring Something needs to be cleaned up or refactored label Sep 25, 2020
@bobheadxi bobheadxi changed the title reduce reliance on 'team refresh' (or even remove it) reduce reliance on 'team refresh' Sep 29, 2020
@bobheadxi
Copy link
Member Author

From #504

I know we talked about possibly dropping refresh (#490), but we still need a way to perform the initial sync - I imagine refresh might stay around purely for use cases like this.

Updated title accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:refactoring Something needs to be cleaned up or refactored
Projects
None yet
Development

No branches or pull requests

1 participant