Updated Jupyterlab #451
Updated Jupyterlab #451
Conversation
✅ Deploy Preview for tweag-jupyterwith ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
GTrunSec
force-pushed
the
jupyterlab-update
branch
from
61384a8
to
f13ff5d
Compare
GTrunSec
force-pushed
the
jupyterlab-update
branch
from
46b7c9e
to
01719d4
Compare
|
@garbas sure. |
There was a problem hiding this comment.
Looks good to me, except the preferWheels, change.
I've looked at the release notes since jupyterlab 3.5.0 and found this two PRs might be cause some problems since they touch some cirectories stuctures:
- use jupyter_config_dir instead of config_path[0] for workspaces, settings jupyterlab/jupyterlab#13589
- Fix
preferred_dirfor examples jupyterlab/jupyterlab#13788
At the same time I found an interesting PR we should be keeping an eye on since it will allow us to have less hacky per environment config: jupyterlab/jupyterlab#12916
lib/jupyter.nix
Outdated
| @@ -23,7 +23,7 @@ | |||
| python ? pkgs.python3, | |||
| editablePackageSources ? {}, | |||
| extraPackages ? (ps: []), | |||
| preferWheels ? false, | |||
| preferWheels ? true, | |||
There was a problem hiding this comment.
| preferWheels ? true, | |
| preferWheels ? false, |
Why is this needed? I'd prefer to build without wheels since that can cause some weird problems by my experience. I understand this options might be interesting for final users since it would speed things up, but for core stuff here we can be on the side of causion and build things from source.
There was a problem hiding this comment.
cause some weird problems
So hard to resolve some dependencies. We can override some packages for building without preferWheels, such as jupyterlab, jupyter -server.
Signed-off-by: Rok Garbas <[email protected]>
fixes: #440