Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM macOS support #496

Closed
wants to merge 1 commit into from
Closed

ARM macOS support #496

wants to merge 1 commit into from

Conversation

wokalski
Copy link

@wokalski wokalski commented Jun 3, 2023

Fixes #388

I was able to run jupyterlab successfully after this change. Let me know if I'm missing anything!

Signed-off-by: Wojtek Czekalski <[email protected]>
@netlify
Copy link

netlify bot commented Jun 3, 2023

Deploy Preview for tweag-jupyterwith ready!

Name Link
🔨 Latest commit 61dd90d
🔍 Latest deploy log https://app.netlify.com/sites/tweag-jupyterwith/deploys/647b15b310c7cc0008c958c2
😎 Deploy Preview https://deploy-preview-496--tweag-jupyterwith.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@srid
Copy link

srid commented Jul 4, 2023

Also need to modify the template,

flake-utils.lib.eachSystem
[
flake-utils.lib.system.x86_64-linux
]

I observe that this project has no CI for macOS? How will macOS support be tested in CI going forward?

@richban
Copy link

richban commented Aug 26, 2023

➜ nix run
warning: Git tree '/Users/richard.banyi/Developer/nix-project-flakes' is dirty
error: attribute 'aarch64-darwin' missing

       at /nix/store/nvss7vjwjdq6prxfwf24swzksn4f6cvm-source/jupyenv/flake.nix:32:18:

           31|       system: let
           32|         inherit (jupyenv.lib.${system}) mkJupyterlabNew;
             |                  ^
           33|         jupyterlab = mkJupyterlabNew ({...}: {
(use '--show-trace' to show detailed location information)

@srid
Copy link

srid commented Sep 25, 2023

Ping.

Can we get this PR merged?

@GTrunSec
Copy link
Collaborator

Could you re-submit the commits to adding these systems? @wokalski

  systems = [
        "x86_64-linux"
        "x86_64-darwin"
        "aarch64-linux"
        "aarch64-darwin"
      ];

@wokalski
Copy link
Author

Sorry. I ended up not using it so i dont have interest working on this.

@wokalski wokalski closed this Sep 28, 2023
@GTrunSec
Copy link
Collaborator

it's ok, im going to refactor the jupyenv on this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing aarch64-darwin attributes (support for MacOS M1)
4 participants