Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Regression [<package>]:Bootstrap Evaluator ShallowCopy wrong parameter parser. #514

Open
nc26676027 opened this issue Nov 20, 2024 · 1 comment · May be fixed by #506
Open

Bug/Regression [<package>]:Bootstrap Evaluator ShallowCopy wrong parameter parser. #514

nc26676027 opened this issue Nov 20, 2024 · 1 comment · May be fixed by #506
Assignees
Labels
bug Something isn't working

Comments

@nc26676027
Copy link

What version of Lattigo are you using?

The latest version of lattigo

Does this issue persist with the latest release?

Yes

What were you trying to do?

Enable multi-threading bootstrapping

What were you expecting to happen?

What actually happened?

Reproducibility

Yes

Should be the following:
return &Evaluator{
Parameters: eval.Parameters,
EvaluationKeys: eval.EvaluationKeys,
Mod1Parameters: eval.Mod1Parameters,
S2CDFTMatrix: eval.S2CDFTMatrix,
C2SDFTMatrix: eval.C2SDFTMatrix,
Evaluator: heEvaluator,
xPow2N1: eval.xPow2N1,
xPow2N2: eval.xPow2N2,
xPow2InvN2: eval.xPow2InvN2,
DomainSwitcher: DomainSwitcher,
DFTEvaluator: dft.NewEvaluator(paramsN2, heEvaluator), // Chao add paramsN1 -> paramsN2
Mod1Evaluator: mod1.NewEvaluator(heEvaluator, polynomial.NewEvaluator(paramsN2, heEvaluator), eval.Mod1Parameters),
SkDebug: eval.SkDebug,
}

@nc26676027 nc26676027 added the bug Something isn't working label Nov 20, 2024
@nc26676027 nc26676027 changed the title Bug/Regression [<package>]:Bootstrap Evaluator ShallowCopy wrong parameter paser. Bug/Regression [<package>]:Bootstrap Evaluator ShallowCopy wrong parameter parser. Nov 20, 2024
@lehugueni lehugueni linked a pull request Nov 21, 2024 that will close this issue
5 tasks
@lehugueni
Copy link
Contributor

Thanks! I've added the fix as part of #506

@lehugueni lehugueni self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants