Remove need for ROS_messages redirected named-pipe
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out it's actually possible to directly open a named pipe, so we can do away with the redirect-named-pipe-to-file-in-mod-dir work-around. Not sure why it works now, as from earlier tests we had the impression it didn't, but seeing as this simplifies things quite a bit, I'm not complaining. Note: this also requires changes on the `fs_mod_ros_windows` side, but those will be made in that repository.
|
Merging as the CI failure is not related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out it's actually possible to directly open a named pipe, so we can do away with the redirect-named-pipe-to-file-in-mod-dir work-around.
Not sure why it works now, as from earlier tests we had the impression it didn't, but seeing as this simplifies things quite a bit, I'm not complaining.
See tud-cor/fs_mod_ros_windows#10 for the changes on the
fs_mod_ros_windowsside.