Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disjoint2/1 succeeds with negative widths and heights #34

Open
SaGagnon opened this issue Oct 27, 2024 · 3 comments
Open

disjoint2/1 succeeds with negative widths and heights #34

SaGagnon opened this issue Oct 27, 2024 · 3 comments

Comments

@SaGagnon
Copy link

Hi,

First of all, thanks a lot for this amazing library.

While using and testing the predicate disjoint/2, I noticed that the following query succeeds:

?- disjoint2([r(1,1,1,1), r(2,-2,2,-2)]).
true.

I see two problems:

  1. It could be argued that negative widths and heights are possible, but I think it is confusing. Also, the Global Constraint Catalog constrains sizes to be >=0 for diffn.
  2. Otherwise, if we allow negative widths and heights, I think it would be more intuitive if this query fails.

If you agree with one of the two points, I would like to try to make a contribution.

@SaGagnon SaGagnon changed the title disjoint2/1 succeeds disjoint2/1 succeeds with negative widths and heights Oct 27, 2024
@triska
Copy link
Owner

triska commented Oct 27, 2024

Thank you a lot for your kind words, and for your interest in this library!

Could you please test the query with a version of SICStus Prolog (an evaluation version is available at no cost), and see what it says? I think it would be good to ensure compatibility of this constraint with SICStus Prolog. Thank you a lot!

@UWN
Copy link

UWN commented Oct 27, 2024

SICStus succeeds. Obsolescent.

@SaGagnon
Copy link
Author

Sadly, I already used my free trial for SICStus Prolog. In light of what UWN said, do you still want a correction or do you want to preserve the same behavior as SICStus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants