Feat/clone object util to more performant and handle cyclic objects #15622
+44
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karliatto
requested review from
mroz22,
szymonlesisz,
martykan and
marekrjpolak
as code owners
|
I remember we there was some reason why we ended up using super stupid clone object (json stringify, json parse). But I don't remember details. 🤔 |
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12071428323 |
* makes cloneObject utils 3 times more efficient * handles cloning objects with cyclic references
trezor-ci
force-pushed
the
feat/cloneObject-util-to-more-performant-and-handle-cyclic-objects
branch
from
633a43e
to
a3c7eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the util
cloneObjectwith new that is more efficient and supports copying object with cyclic references instead of throwing error or missing the object. Adding also tests.You can test the performance yourself with the code in gist: https://gist.github.com/karliatto/32c8b1b26f39f0b1fafb49318c760d7f
Copying 1000 objects results in: